From 9b8a9df6f7a66d1eae0b6eca1768125dba1444e4 Mon Sep 17 00:00:00 2001 From: silverwind Date: Tue, 26 Sep 2023 21:29:48 +0200 Subject: [PATCH 1/3] Add missed return to actions view fetch --- web_src/js/components/RepoActionView.vue | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/web_src/js/components/RepoActionView.vue b/web_src/js/components/RepoActionView.vue index da06dd9cb60dd..55e609b8512cf 100644 --- a/web_src/js/components/RepoActionView.vue +++ b/web_src/js/components/RepoActionView.vue @@ -225,7 +225,11 @@ const sfc = { this.fetchArtifacts(), // refresh artifacts if upload-artifact step done ]); } catch (err) { - if (!(err instanceof TypeError)) throw err; // avoid network error while unloading page + if (err instanceof TypeError) { + return; // avoid network error while unloading page + } else { + throw err; + } } this.artifacts = artifacts['artifacts'] || []; From db35f2f71f299305bbab3290486c33e8a7dcb72a Mon Sep 17 00:00:00 2001 From: silverwind Date: Tue, 26 Sep 2023 21:34:45 +0200 Subject: [PATCH 2/3] fix lint --- web_src/js/components/RepoActionView.vue | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/web_src/js/components/RepoActionView.vue b/web_src/js/components/RepoActionView.vue index 55e609b8512cf..916fb07a82df9 100644 --- a/web_src/js/components/RepoActionView.vue +++ b/web_src/js/components/RepoActionView.vue @@ -227,9 +227,8 @@ const sfc = { } catch (err) { if (err instanceof TypeError) { return; // avoid network error while unloading page - } else { - throw err; } + throw err; } this.artifacts = artifacts['artifacts'] || []; From f2b53d90a9b086e50b6831cf1dd97011d211be77 Mon Sep 17 00:00:00 2001 From: silverwind Date: Tue, 26 Sep 2023 21:35:32 +0200 Subject: [PATCH 3/3] condense --- web_src/js/components/RepoActionView.vue | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/web_src/js/components/RepoActionView.vue b/web_src/js/components/RepoActionView.vue index 916fb07a82df9..797869b78cead 100644 --- a/web_src/js/components/RepoActionView.vue +++ b/web_src/js/components/RepoActionView.vue @@ -225,9 +225,7 @@ const sfc = { this.fetchArtifacts(), // refresh artifacts if upload-artifact step done ]); } catch (err) { - if (err instanceof TypeError) { - return; // avoid network error while unloading page - } + if (err instanceof TypeError) return; // avoid network error while unloading page throw err; }