Skip to content

Don't list root repository on compare page if pulls not allowed (#24183) #24210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 19, 2023
Merged

Don't list root repository on compare page if pulls not allowed (#24183) #24210

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0e77e20
Don't list root repository on compare page if pulls not allowed (#24183)
lunny Apr 19, 2023
8565bb4
Merge branch 'release/v1.19' into backport-24183-v1.19
GiteaBot Apr 19, 2023
135b02d
Merge branch 'release/v1.19' into backport-24183-v1.19
GiteaBot Apr 19, 2023
11e8f33
Merge branch 'release/v1.19' into backport-24183-v1.19
GiteaBot Apr 19, 2023
43d5e7b
Merge branch 'release/v1.19' into backport-24183-v1.19
GiteaBot Apr 19, 2023
2b17435
Merge branch 'release/v1.19' into backport-24183-v1.19
GiteaBot Apr 19, 2023
6d1d29b
Merge branch 'release/v1.19' into backport-24183-v1.19
GiteaBot Apr 19, 2023
d650572
Merge branch 'release/v1.19' into backport-24183-v1.19
GiteaBot Apr 19, 2023
27eff8b
Merge branch 'release/v1.19' into backport-24183-v1.19
GiteaBot Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion routers/web/repo/compare.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ func ParseCompareInfo(ctx *context.Context) *CompareInfo {
rootRepo.ID != ci.HeadRepo.ID &&
rootRepo.ID != baseRepo.ID {
canRead := access_model.CheckRepoUnitUser(ctx, rootRepo, ctx.Doer, unit.TypeCode)
if canRead {
if canRead && rootRepo.AllowsPulls() {
ctx.Data["RootRepo"] = rootRepo
if !fileOnly {
branches, tags, err := getBranchesAndTagsForRepo(ctx, rootRepo)
Expand Down