Skip to content

Remove applySVGInnerHTMLFix 🤞 #1775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove applySVGInnerHTMLFix 🤞 #1775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 0 additions & 118 deletions packages/@glimmer/runtime/lib/compat/svg-inner-html-fix.ts
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions packages/@glimmer/runtime/lib/dom/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,8 @@ import type {
SimpleDocument,
SimpleElement,
} from '@glimmer/interfaces';
import { NS_SVG } from '@glimmer/constants';
import { castToSimple } from '@glimmer/debug-util';

import { applySVGInnerHTMLFix } from '../compat/svg-inner-html-fix';
import { applyTextNodeMergingFix } from '../compat/text-node-merging-fix';
import { DOMOperations } from './operations';

Expand Down Expand Up @@ -40,11 +38,6 @@ appliedTreeConstruction = applyTextNodeMergingFix(
doc,
appliedTreeConstruction
) as typeof TreeConstruction;
appliedTreeConstruction = applySVGInnerHTMLFix(
doc,
appliedTreeConstruction,
NS_SVG
) as typeof TreeConstruction;

export const DOMTreeConstruction = appliedTreeConstruction;
export type DOMTreeConstruction = TreeConstruction;
3 changes: 0 additions & 3 deletions packages/@glimmer/runtime/lib/dom/helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,8 @@ import type {
SimpleElement,
SimpleNode,
} from '@glimmer/interfaces';
import { NS_SVG } from '@glimmer/constants';
import { castToSimple } from '@glimmer/debug-util';

import { applySVGInnerHTMLFix } from '../compat/svg-inner-html-fix';
import { applyTextNodeMergingFix } from '../compat/text-node-merging-fix';
import { BLACKLIST_TABLE, DOMOperations } from './operations';

Expand Down Expand Up @@ -93,7 +91,6 @@ export class DOMChangesImpl extends DOMOperations implements GlimmerTreeChanges
let helper = DOMChangesImpl;

helper = applyTextNodeMergingFix(doc, helper) as typeof DOMChangesImpl;
helper = applySVGInnerHTMLFix(doc, helper, NS_SVG) as typeof DOMChangesImpl;

export const DOMChanges = helper;
export { DOMTreeConstruction } from './api';
Loading