Support for Docker multi host networking #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the Docker multi-host networking, IPAddress under NetworkSettings is set to an empty string and the container IP can be retrieved from NetworkSettings.Networks. At this point it is assumed a single Docker network is associated with the container
|
+1 Can I help somehow to get this merged? |
Contributor
|
Can I get some verifications that this is a good and working PR? |
|
I will try to build an image and test it ... that's a needed feature 👍 |
|
I have been using an image by kidibox (kidibox/registrator) with this pull request merged and it has worked as it should with overlay networking with the "-internal" flag. The problem is that an unnecessary number of ports (all that are EXPOSEd in the Dockerfile) get registered, some way to better control the ports would be preferred. Maybe a environment variable would do? |
Contributor
|
Definitely sounds like more configuration is necessary for that use case, but that would be a separate issue/PR. I'll merge and if there are problems somebody please reopen. |
progrium
added a commit
that referenced
this pull request
Jan 5, 2016
Support for Docker multi host networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Docker multi-host networking, IPAddress under NetworkSettings is set to an empty string and the container IP can be retrieved from NetworkSettings.Networks.
At this point it is assumed a single Docker network is associated with the container