Retries to backend in the startup #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Salazar R <[email protected]>
Signed-off-by: Marcelo Salazar R <[email protected]>
Conflicts: bridge/bridge.go
bridge/types.go
Outdated
Contributor
There was a problem hiding this comment.
I don't think these are needed any longer.
Contributor
|
Looks pretty good now, just remove those fields which are no longer needed right? |
progrium
added a commit
that referenced
this pull request
Sep 1, 2015
Retries to backend in the startup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registrator doesn't have resilience in the startup when you are trying to connect to an offline or starting up backend.
In my use case I'm using docker-compose to get my dev-cluster with consul and consul-template up, but I have some troubles when registrator run first than Consul.
I added two parameters: