Don't dedupe enums structurally for C# (can't totally fix for Python/Go until we remove Quicktype)

Co-Authored-By: Copilot <223556219+Copilot@users.noreply.github.com>

Author: SteveSandersonMS

dotnet/src/Generated/Rpc.cs

@@ -302,11 +302,9 @@ interface EventVariant {
 let generatedEnums = new Map<string, { enumName: string; values: string[] }>();
 
 function getOrCreateEnum(parentClassName: string, propName: string, values: string[], enumOutput: string[], description?: string, explicitName?: string): string {
-    const valuesKey = [...values].sort().join("|");
-    for (const [, existing] of generatedEnums) {
-        if ([...existing.values].sort().join("|") === valuesKey) return existing.enumName;
-    }
     const enumName = explicitName ?? `${parentClassName}${propName}`;
+    const existing = generatedEnums.get(enumName);
+    if (existing) return existing.enumName;
     generatedEnums.set(enumName, { enumName, values });
 
     const lines: string[] = [];
@@ -992,10 +990,10 @@ function emitServerInstanceMethod(
         const isReq = requiredSet.has(pName);
         const jsonSchema = pSchema as JSONSchema7;
         let csType: string;
-        // If the property has an enum, resolve to the generated enum type
+        // If the property has an enum, resolve to the generated enum type by title
         if (jsonSchema.enum && Array.isArray(jsonSchema.enum) && requestClassName) {
-            const valuesKey = [...jsonSchema.enum].sort().join("|");
-            const match = [...generatedEnums.values()].find((e) => [...e.values].sort().join("|") === valuesKey);
+            const enumTitle = (jsonSchema.title as string) ?? `${requestClassName}${toPascalCase(pName)}`;
+            const match = generatedEnums.get(enumTitle);
             csType = match ? (isReq ? match.enumName : `${match.enumName}?`) : schemaTypeToCSharp(jsonSchema, isReq, rpcKnownTypes);
         } else {
             csType = schemaTypeToCSharp(jsonSchema, isReq, rpcKnownTypes);

dotnet/src/Generated/SessionEvents.cs

@@ -214,7 +214,7 @@ interface GoEventVariant {
 interface GoCodegenCtx {
     structs: string[];
     enums: string[];
-    enumsByValues: Map<string, string>; // sorted-values-key → enumName
+    enumsByName: Map<string, string>; // enumName → enumName (dedup by type name, not values)
     generatedNames: Set<string>;
 }
 
@@ -268,16 +268,16 @@ function findGoDiscriminator(
 }
 
 /**
- * Get or create a Go enum type, deduplicating by value set.
+ * Get or create a Go enum type, deduplicating by type name (not by value set).
+ * Two enums with the same values but different names are distinct types.
  */
 function getOrCreateGoEnum(
     enumName: string,
     values: string[],
     ctx: GoCodegenCtx,
     description?: string
 ): string {
-    const valuesKey = [...values].sort().join("|");
-    const existing = ctx.enumsByValues.get(valuesKey);
+    const existing = ctx.enumsByName.get(enumName);
     if (existing) return existing;
 
     const lines: string[] = [];
@@ -302,7 +302,7 @@ function getOrCreateGoEnum(
     }
     lines.push(`)`);
 
-    ctx.enumsByValues.set(valuesKey, enumName);
+    ctx.enumsByName.set(enumName, enumName);
     ctx.enums.push(lines.join("\n"));
     return enumName;
 }
@@ -578,7 +578,7 @@ function generateGoSessionEventsCode(schema: JSONSchema7): string {
     const ctx: GoCodegenCtx = {
         structs: [],
         enums: [],
-        enumsByValues: new Map(),
+        enumsByName: new Map(),
         generatedNames: new Set(),
     };