Skip to content

Conversation

@appleboy
Copy link
Member

@appleboy appleboy commented Apr 6, 2021

as title. cc @thinkerou

@appleboy appleboy requested a review from thinkerou April 6, 2021 02:57
@appleboy
Copy link
Member Author

appleboy commented Apr 6, 2021

@thinkerou We should add changelog before release v1.7.0?

@appleboy appleboy added this to the 1.7 milestone Apr 6, 2021
@thinkerou
Copy link
Member

@thinkerou We should add changelog before release v1.7.0?

yes, thanks!

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #2672 (badb498) into master (bfc8ca2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2672   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files          41       41           
  Lines        2038     2038           
=======================================
  Hits         2011     2011           
  Misses         15       15           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfc8ca2...badb498. Read the comment docs.

thinkerou
thinkerou previously approved these changes Apr 6, 2021
@appleboy appleboy requested a review from thinkerou April 8, 2021 02:33
@appleboy
Copy link
Member Author

appleboy commented Apr 8, 2021

@thinkerou Done. Please review again.

Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@appleboy appleboy merged commit d496f64 into master Apr 8, 2021
@appleboy appleboy deleted the appleboy-patch-1 branch April 8, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants