Skip to content

Conversation

@ImadSaddik
Copy link
Contributor

@ImadSaddik ImadSaddik commented Oct 8, 2025

Hi Mitchell,

I found a weird bug in the sidecar component. It seems that if we don't use unique headers, the code gets confused and starts duplicating the items in the sidecar.

Here is a video demonstrating the issue. Look how Dependencies is being duplicated every time it gets highlighted.

problem_demo.mp4

I know that in Markdown we should have unique headers:

Rationale: Some Markdown parsers generate anchors for headings based on the heading name; headings with the same content can cause problems with that.

I tried changing the headers to be unique and that solved the issue.

problem_fixed.mp4

I think changing the mdx files to use unique headers is better than twisting the code to work in this weird case.

I haven't checked the other markdown files, but if I find any that has the same issue, I will fix it and add the changes here.

Edit: It seems that #383 solved the issue. I will close the PR.

@vercel
Copy link

vercel bot commented Oct 8, 2025

@ImadSaddik is attempting to deploy a commit to the Ghostty Team on Vercel.

A member of the Team first needs to authorize it.

@ImadSaddik ImadSaddik changed the title Fixed Fix: Headers with same name break the sidecar behavior Oct 8, 2025
@ImadSaddik ImadSaddik closed this Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant