Skip to content

Commit b07cda6

Browse files
0Marble5ujinKang
andauthored
CANN: implement the SSM_CONV operator (#17737)
* CANN: implement SSM_CONV operator Co-authored-by: Aleksei Lobanov, <zeromarblectm@gmail.com> Co-authored-by: Sujin Kang, <waterjin326@gmail.com> * CANN: remove custom error limit for SSM_CONV * CANN: merge SSM_CONV tensor shape/strides into one line --------- Co-authored-by: Sujin Kang, <waterjin326@gmail.com>
1 parent 85c40c9 commit b07cda6

File tree

3 files changed

+109
-0
lines changed

3 files changed

+109
-0
lines changed

ggml/src/ggml-cann/aclnn_ops.cpp

Lines changed: 103 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3702,3 +3702,106 @@ void ggml_cann_out_prod(ggml_backend_cann_context & ctx, ggml_tensor * dst) {
37023702
break;
37033703
}
37043704
}
3705+
3706+
void ggml_cann_ssm_conv(ggml_backend_cann_context & ctx, ggml_tensor * dst) {
3707+
ggml_tensor * src0 = dst->src[0]; // conv_x
3708+
ggml_tensor * src1 = dst->src[1]; // conv1d.weight
3709+
3710+
// This op is currently defined only for F32 in ggml_cpu
3711+
GGML_ASSERT(src0->type == GGML_TYPE_F32);
3712+
GGML_ASSERT(src1->type == GGML_TYPE_F32);
3713+
GGML_ASSERT(dst->type == GGML_TYPE_F32);
3714+
3715+
// Shapes follow ggml_compute_forward_ssm_conv_f32
3716+
const int64_t nc = src1->ne[0]; // d_conv
3717+
const int64_t ncs = src0->ne[0]; // d_conv - 1 + n_t
3718+
const int64_t nr = src0->ne[1]; // d_inner
3719+
const int64_t n_s = src0->ne[2]; // n_seqs
3720+
3721+
const int64_t n_t = dst->ne[1]; // tokens per sequence
3722+
3723+
GGML_ASSERT(dst->ne[0] == nr); // dst: {d_inner, n_t, n_s}
3724+
GGML_ASSERT(src1->ne[1] == nr); // weight: {d_conv, d_inner}
3725+
GGML_ASSERT(ncs == nc - 1 + n_t); // conv_x: {d_conv - 1 + n_t, d_inner, n_s}
3726+
GGML_ASSERT(src0->nb[0] == sizeof(float));
3727+
GGML_ASSERT(src1->nb[0] == sizeof(float));
3728+
3729+
// --- Build CANN tensors ---
3730+
3731+
// 1) Input: conv_x as NCL
3732+
//
3733+
// src0->ne = { ncs, nr, n_s, 1 } // {L_in, C, N}
3734+
// Passing ACL_FORMAT_NCL here means:
3735+
// reversed dims -> [N, C, L_in] = [n_s, nr, ncs]
3736+
acl_tensor_ptr acl_x = ggml_cann_create_tensor(src0, src0->ne, src0->nb, 3, ACL_FORMAT_NCL);
3737+
3738+
// 2) Weights: depthwise conv kernel, view src1 as {K, 1, C}
3739+
//
3740+
// src1 original: ne = { nc, nr, 1, 1 } // [K, C, 1, 1]
3741+
// we want a view: ne_w = { nc, 1, nr } // [K, 1, C]
3742+
// so that reversed dims -> [C, 1, K] which matches
3743+
// [out_channels, in_channels/groups, kernel_size]
3744+
int64_t w_ne[GGML_MAX_DIMS] = { nc, 1, nr, 1 }; // [K, 1 input ch. per group, C groups]
3745+
// Layout: src1 data is [K, C] with
3746+
// offset(k, c) = k*nb0 + c*nb1
3747+
// We want offset_w(k, 0, c) = k*nb0 + c*nb1,
3748+
// so we can reuse nb0 and nb1, and set nb2 = nb1.
3749+
size_t w_nb[GGML_MAX_DIMS] = { src1->nb[0], src1->nb[1], src1->nb[1], src1->nb[3] }; // same as src1
3750+
3751+
acl_tensor_ptr acl_w = ggml_cann_create_tensor(
3752+
src1->data, ggml_cann_type_mapping(src1->type), ggml_type_size(src1->type), w_ne, w_nb, 3, ACL_FORMAT_NCL);
3753+
3754+
// 3) Output: dst is { d_inner, n_t, n_s } (CLN)
3755+
//
3756+
// We need an NCL view of the same buffer:
3757+
// desired NCL logical shape: { L_out = n_t, C = nr, N = n_s }
3758+
//
3759+
// Original CLN layout:
3760+
// dst->ne = { nr, n_t, n_s }
3761+
// dst->nb[0] = sizeof(float)
3762+
// dst->nb[1] = nr * sizeof(float)
3763+
// dst->nb[2] = nr * n_t * sizeof(float)
3764+
//
3765+
// We want offset_new(L, C, N) = offset_orig(C, L, N).
3766+
// Choose:
3767+
// nb_y[0] = nr * sizeof(float); // step in L
3768+
// nb_y[1] = sizeof(float); // step in C
3769+
// nb_y[2] = nr * n_t * sizeof(float); // step in N
3770+
int64_t y_ne[GGML_MAX_DIMS] = { n_t, nr, n_s, 1 }; // [L_out, C, N]
3771+
size_t y_nb[GGML_MAX_DIMS] = { dst->ne[0] * sizeof(float), sizeof(float), dst->ne[0] * dst->ne[1] * sizeof(float), dst->nb[3] }; // [nr, 1, nr * n_t]
3772+
3773+
acl_tensor_ptr acl_y = ggml_cann_create_tensor(
3774+
dst->data, ggml_cann_type_mapping(dst->type), ggml_type_size(dst->type), y_ne, y_nb, 3, ACL_FORMAT_NCL);
3775+
3776+
// --- Conv1d parameters: depthwise, stride 1, no padding ("valid") ---
3777+
int64_t strideVal[1] = { 1 };
3778+
int64_t paddingVal[1] = { 0 };
3779+
int64_t dilationVal[1] = { 1 };
3780+
3781+
acl_int_array_ptr stride = ggml_cann_create_int_array(strideVal, 1);
3782+
acl_int_array_ptr padding = ggml_cann_create_int_array(paddingVal, 1);
3783+
acl_int_array_ptr dilation = ggml_cann_create_int_array(dilationVal, 1);
3784+
3785+
const bool transposed = false;
3786+
const int64_t groups = nr; // depthwise: one group per inner dim
3787+
int8_t cubeMathType = 0;
3788+
3789+
#ifdef ASCEND_310P
3790+
cubeMathType = 1;
3791+
#endif
3792+
3793+
GGML_CANN_CALL_ACLNN_OP(ctx,
3794+
Convolution,
3795+
acl_x.get(), // input: N, C, L_in = ncs
3796+
acl_w.get(), // weight: [C, 1, K] with groups=nr
3797+
nullptr, // bias
3798+
stride.get(),
3799+
padding.get(),
3800+
dilation.get(),
3801+
transposed,
3802+
padding.get(), // output padding (unused for non-transposed)
3803+
groups,
3804+
acl_y.get(),
3805+
cubeMathType);
3806+
}
3807+

ggml/src/ggml-cann/aclnn_ops.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1033,6 +1033,8 @@ void ggml_cann_op_unary(std::function<void(ggml_backend_cann_context &, aclTenso
10331033
ggml_backend_cann_context & ctx,
10341034
ggml_tensor * dst);
10351035

1036+
void ggml_cann_ssm_conv(ggml_backend_cann_context & ctx, ggml_tensor * dst);
1037+
10361038
/**
10371039
* @brief Applies a gated (GLU-style) unary operation using the CANN backend.
10381040
*

ggml/src/ggml-cann/ggml-cann.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1888,6 +1888,8 @@ static bool ggml_cann_compute_forward(ggml_backend_cann_context & ctx, struct gg
18881888
break;
18891889
case GGML_OP_OUT_PROD:
18901890
ggml_cann_out_prod(ctx, dst);
1891+
case GGML_OP_SSM_CONV:
1892+
ggml_cann_ssm_conv(ctx, dst);
18911893
break;
18921894
default:
18931895
return false;
@@ -2471,6 +2473,8 @@ static bool ggml_backend_cann_supports_op(ggml_backend_dev_t dev, const ggml_ten
24712473
}
24722474
return true;
24732475
}
2476+
case GGML_OP_SSM_CONV:
2477+
return true;
24742478
default:
24752479
return false;
24762480
}

0 commit comments

Comments
 (0)