Skip to content

Commit 2764aaa

Browse files
committed
add support for -st flag in embedding model conversion
This commit add support for the -st flag in the embedding model conversion script. This will enable models to be converted using sentence transformers dense layers.
1 parent 08337c3 commit 2764aaa

File tree

2 files changed

+23
-1
lines changed

2 files changed

+23
-1
lines changed

examples/model-conversion/Makefile

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,12 @@ embedding-convert-model:
116116
METADATA_OVERRIDE="$(METADATA_OVERRIDE)" \
117117
./scripts/embedding/convert-model.sh
118118

119+
embedding-convert-model-st:
120+
$(call validate_embedding_model_path,embedding-convert-model-st)
121+
@MODEL_NAME="$(MODEL_NAME)" OUTTYPE="$(OUTTYPE)" MODEL_PATH="$(EMBEDDING_MODEL_PATH)" \
122+
METADATA_OVERRIDE="$(METADATA_OVERRIDE)" \
123+
./scripts/embedding/convert-model.sh -st
124+
119125
embedding-run-original-model:
120126
$(call validate_embedding_model_path,embedding-run-original-model)
121127
@EMBEDDING_MODEL_PATH="$(EMBEDDING_MODEL_PATH)" \

examples/model-conversion/scripts/embedding/convert-model.sh

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,21 @@
22

33
set -e
44

5+
# Parse command line arguments
6+
SENTENCE_TRANSFORMERS=""
7+
while [[ $# -gt 0 ]]; do
8+
case $1 in
9+
-st|--sentence-transformers)
10+
SENTENCE_TRANSFORMERS="--sentence-transformers-dense-modules"
11+
shift
12+
;;
13+
*)
14+
echo "Unknown option: $1"
15+
exit 1
16+
;;
17+
esac
18+
done
19+
520
MODEL_NAME="${MODEL_NAME:-$(basename "$EMBEDDING_MODEL_PATH")}"
621
OUTPUT_DIR="${OUTPUT_DIR:-../../models}"
722
TYPE="${OUTTYPE:-f16}"
@@ -15,7 +30,8 @@ echo "Converted model path:: ${CONVERTED_MODEL}"
1530
python ../../convert_hf_to_gguf.py --verbose \
1631
${EMBEDDING_MODEL_PATH} \
1732
--outfile ${CONVERTED_MODEL} \
18-
--outtype ${TYPE}
33+
--outtype ${TYPE} \
34+
${SENTENCE_TRANSFORMERS}
1935

2036
echo ""
2137
echo "The environment variable CONVERTED_EMBEDDING MODEL can be set to this path using:"

0 commit comments

Comments
 (0)