Skip to content

Conversation

@loewenheim
Copy link
Contributor

@loewenheim loewenheim commented Apr 21, 2023

#skip-changelog

@loewenheim loewenheim linked an issue Apr 21, 2023 that may be closed by this pull request
@Swatinem Swatinem changed the title WIP: Don't use Url type in js processing Don't use Url type in js processing Apr 21, 2023
@Swatinem Swatinem marked this pull request as ready for review April 21, 2023 13:06
@Swatinem Swatinem requested a review from a team April 21, 2023 13:06
@github-actions
Copy link
Contributor

Warnings
⚠️ Snapshot changes likely affect Sentry tests. If the Sentry-Symbolicator Integration Tests in CI are failing for your PR, please check the symbolicator test suite in Sentry and update snapshots as needed.
Instructions for snapshot changes

Sentry runs a symbolicator integration test suite located at tests/symbolicator/. Changes in this PR will likely result in snapshot diffs in Sentry, which will break the master branch and in-progress PRs.

Follow these steps to update snapshots in Sentry:

  1. Check out latest Sentry master and enable the virtualenv.
  2. Enable symbolicator (symbolicator: true) in sentry via ~/.sentry/config.yml.
  3. Make sure your other devservices are running via sentry devservices up --exclude symbolicator. If
    they're already running, stop symbolicator with sentry devservices down symbolicator. You want to use your
    own development symbolicator to update the snapshots.
  4. Run your development symbolicator on port 3021, or whatever port symbolicator is configured to use
    in ~/.sentry/config.yml.
  5. Export SENTRY_SNAPSHOTS_WRITEBACK=1 to automatically update the existing snapshots with your new
    results and run symbolicator tests with pytest (pytest tests/symbolicator).
  6. Review snapshot changes locally, then create a PR to Sentry.
  7. Merge the Symbolicator PR, then merge the Sentry PR.

Generated by 🚫 dangerJS against 2a5e0b5

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #1154 (2a5e0b5) into master (9d041ca) will increase coverage by 0.04%.
The diff coverage is 97.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1154      +/-   ##
==========================================
+ Coverage   73.94%   73.98%   +0.04%     
==========================================
  Files          86       86              
  Lines       12864    12877      +13     
==========================================
+ Hits         9512     9527      +15     
+ Misses       3352     3350       -2     

@Swatinem Swatinem merged commit 8c3ee0d into master Apr 21, 2023
@Swatinem Swatinem deleted the fix/js-no-url branch April 21, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reconsider using Url for JS processing

3 participants