Skip to content

feat(taskworker): Zstd compress process profile task #95545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2025
Merged

feat(taskworker): Zstd compress process profile task #95545

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01595fa
zstd compress process profile task
enochtangg Jul 15, 2025
bfc5ea6
add double compression unit test
enochtangg Jul 15, 2025
030c239
typing
enochtangg Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sentry/profiles/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
from sentry.silo.base import SiloMode
from sentry.tasks.base import instrumented_task
from sentry.taskworker.config import TaskworkerConfig
from sentry.taskworker.constants import CompressionType
from sentry.taskworker.namespaces import ingest_profiling_tasks
from sentry.taskworker.retry import Retry
from sentry.utils import json, metrics
Expand Down Expand Up @@ -137,6 +138,7 @@ def encode_payload(message: dict[str, Any]) -> str:
times=2,
delay=5,
),
compression_type=CompressionType.ZSTD,
Copy link
Member

@markstory markstory Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll end up double zipping here as the profiles consumer will do one zip, and then the taskworker system will zip again. This isn't ideal, but as an intermediary step it should be ok. We should test this locally to make sure we're not going to break the tasks.

),
)
def process_profile_task(
Expand Down
Loading