ref(auto_source_config): Support multiple code mappings asserted #87915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of expecting that only one could be created.
armenzg
commented
Mar 25, 2025
tests/sentry/issues/auto_source_code_config/test_process_event.py
Outdated
Show resolved
Hide resolved
armenzg
commented
Mar 26, 2025
| self, | ||
| filename: str | None = None, | ||
| in_app: bool | None = True, | ||
| module: str | None = None, |
Member
Author
There was a problem hiding this comment.
The Java tests were not taking advantage of this helper function.
| frame["in_app"] = in_app | ||
| return frame | ||
|
|
||
| def code_mapping( |
Member
Author
There was a problem hiding this comment.
This will help make multi-line code mappings a single line:
| repo_trees={REPO1: [file_in_repo]}, | ||
| frames=[self.frame(frame_filename, True)], | ||
| platform=platform, | ||
| expected_new_code_mapping={ |
Member
Author
There was a problem hiding this comment.
From here forward, we're swapping to use self.frame and self.code_mapping.
MichaelSun48
approved these changes
Mar 26, 2025
Contributor
MichaelSun48
left a comment
MichaelSun48
left a comment
There was a problem hiding this comment.
nice reduction in LOC!
armenzg
deleted the
ref/multiple_code_mappings/auto_source_config/armenzg
branch
armenzg
added this to the
Automate Code Mappings & In-App Stack Trace Rules for Java projects milestone
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables tests to assert that multiple code mappings are created rather than just one.
This also adds:
code_mappingfunctionframehelper