From 1c8691e1298cc3af4fb7ba77dfeafda6bf476e8d Mon Sep 17 00:00:00 2001 From: Ayesha Waseem Date: Sat, 10 Oct 2026 18:08:53 +0500 Subject: [PATCH] fix(seer): Stop the repo table bulk action menus from being clipped The Code Review and Triggers selects sit inside a table header cell whose label wrappers are overflow: hidden, so the open menu was cut to a few pixels and its options could not be clicked. Position both menus with the fixed strategy so they render outside the cell. --- .../repoTable/seerRepoTableHeader.spec.tsx | 57 +++++++++++++++++++ .../seer/repoTable/seerRepoTableHeader.tsx | 2 + 2 files changed, 59 insertions(+) create mode 100644 static/app/components/seer/repoTable/seerRepoTableHeader.spec.tsx diff --git a/static/app/components/seer/repoTable/seerRepoTableHeader.spec.tsx b/static/app/components/seer/repoTable/seerRepoTableHeader.spec.tsx new file mode 100644 index 000000000000..c6986ca7fc0f --- /dev/null +++ b/static/app/components/seer/repoTable/seerRepoTableHeader.spec.tsx @@ -0,0 +1,57 @@ +import {OrganizationFixture} from 'sentry-fixture/organization'; +import {RepositoryFixture} from 'sentry-fixture/repository'; + +import {render, screen, userEvent} from 'sentry-test/reactTestingLibrary'; + +import {SeerRepoTableHeader} from 'sentry/components/seer/repoTable/seerRepoTableHeader'; +import {SimpleTable} from 'sentry/components/tables/simpleTable'; +import type {RepositoryWithSettings} from 'sentry/types/integrations'; +import {ListItemCheckboxProvider} from 'sentry/utils/list/useListItemCheckboxState'; + +describe('SeerRepoTableHeader', () => { + const repository: RepositoryWithSettings = { + ...RepositoryFixture({id: '1'}), + settings: { + enabledCodeReview: true, + codeReviewTriggers: ['on_ready_for_review'], + }, + }; + + it.each([ + {trigger: 'Code Review', option: 'Enable'}, + {trigger: 'Triggers', option: 'On New Commit'}, + ])( + 'positions the $trigger menu with the fixed strategy so the header cell cannot clip it', + async ({trigger, option}) => { + render( + + + + + , + {organization: OrganizationFixture({access: ['org:write']})} + ); + + await userEvent.click(screen.getByRole('checkbox')); + await userEvent.click(screen.getByRole('button', {name: trigger})); + + const menu = await screen.findByRole('listbox'); + expect(screen.getByRole('option', {name: option})).toBeInTheDocument(); + expect(menu.closest('[data-overlay]')?.parentElement).toHaveStyle({ + position: 'fixed', + }); + } + ); +}); diff --git a/static/app/components/seer/repoTable/seerRepoTableHeader.tsx b/static/app/components/seer/repoTable/seerRepoTableHeader.tsx index c5bc910b8aee..cc47b7a0c69c 100644 --- a/static/app/components/seer/repoTable/seerRepoTableHeader.tsx +++ b/static/app/components/seer/repoTable/seerRepoTableHeader.tsx @@ -277,6 +277,7 @@ export function SeerRepoTableHeader({ ( {t('Code Review')} @@ -308,6 +309,7 @@ export function SeerRepoTableHeader({ disabled={!canWrite} multiple size="xs" + strategy="fixed" trigger={props => ( {t('Triggers')}