Skip to content

Commit e555ba1

Browse files
committed
ref(crons): Use dateAdded over dateCreated
Requires #91665 to be merged first
1 parent e769bbb commit e555ba1

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

static/app/views/insights/crons/components/monitorCheckIns.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,14 +121,14 @@ export function MonitorCheckIns({monitor, monitorEnvs}: Props) {
121121
disabled={!customTimezone}
122122
title={
123123
<DateTime
124-
date={checkIn.dateCreated}
124+
date={checkIn.dateAdded}
125125
forcedTimezone={monitor.config.timezone ?? 'UTC'}
126126
timeZone
127127
seconds
128128
/>
129129
}
130130
>
131-
<DateTime date={checkIn.dateCreated} timeZone seconds />
131+
<DateTime date={checkIn.dateAdded} timeZone seconds />
132132
</Tooltip>
133133
</div>
134134
)}

static/app/views/insights/crons/types.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,9 @@ export interface MonitorStat {
142142

143143
export interface CheckIn {
144144
/**
145-
* Date the opening check-in was sent
145+
* Date the opening check-in was received.
146146
*/
147-
dateCreated: string;
147+
dateAdded: string;
148148
/**
149149
* Duration (in milliseconds)
150150
*/

static/app/views/issueDetails/groupCheckIns.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ export default function GroupCheckIns() {
9191
emptyMessage={t('No matching check-ins found')}
9292
data={cronData}
9393
columnOrder={[
94-
{key: 'dateCreated', width: 225, name: t('Timestamp')},
94+
{key: 'dateAdded', width: 225, name: t('Timestamp')},
9595
{key: 'status', width: 100, name: t('Status')},
9696
{key: 'duration', width: 130, name: t('Duration')},
9797
{key: 'environment', width: 120, name: t('Environment')},
@@ -146,7 +146,7 @@ function CheckInCell({
146146
}
147147

148148
switch (columnKey) {
149-
case 'dateCreated': {
149+
case 'dateAdded': {
150150
const format = userOptions.clock24Hours
151151
? 'MMM D, YYYY HH:mm:ss z'
152152
: 'MMM D, YYYY h:mm:ss A z';
@@ -176,7 +176,7 @@ function CheckInCell({
176176
</LabelledTooltip>
177177
}
178178
>
179-
{FIELD_FORMATTERS.date.renderFunc('dateCreated', dataRow)}
179+
{FIELD_FORMATTERS.date.renderFunc('dateAdded', dataRow)}
180180
</Tooltip>
181181
</HoverableCell>
182182
);

tests/js/fixtures/checkIn.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export function CheckInFixture(params: Partial<CheckIn> = {}): CheckIn {
66
status: CheckInStatus.ERROR,
77
duration: 767,
88
environment: 'production',
9-
dateCreated: '2025-01-01T00:00:00Z',
9+
dateAdded: '2025-01-01T00:00:00Z',
1010
expectedTime: '2025-01-01T00:00:00Z',
1111
id: '97f0e440-317c-5bb5-b5e0-024ca202a61d',
1212
monitorConfig: {

0 commit comments

Comments
 (0)