Skip to content

Commit 7c4d240

Browse files
committed
fix(ui): Make build details more like release details
Partial fix for EME-318
1 parent 89ee6e7 commit 7c4d240

File tree

1 file changed

+19
-10
lines changed

1 file changed

+19
-10
lines changed

static/app/views/preprod/buildDetails/header/buildDetailsHeaderContent.tsx

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
1+
import React from 'react';
12
import {Link} from 'react-router-dom';
23

34
import {Breadcrumbs, type Crumb} from 'sentry/components/breadcrumbs';
45
import {Button} from 'sentry/components/core/button';
56
import {Flex} from 'sentry/components/core/layout';
6-
import {Heading} from 'sentry/components/core/text';
77
import DropdownButton from 'sentry/components/dropdownButton';
88
import {DropdownMenu} from 'sentry/components/dropdownMenu';
9+
import IdBadge from 'sentry/components/idBadge';
10+
import * as Layout from 'sentry/components/layouts/thirds';
11+
import Version from 'sentry/components/version';
912
import {IconEllipsis, IconTelescope} from 'sentry/icons';
1013
import {t} from 'sentry/locale';
1114
import ProjectsStore from 'sentry/stores/projectsStore';
@@ -98,7 +101,7 @@ export function BuildDetailsHeaderContent(props: BuildDetailsHeaderContentProps)
98101
if (buildDetailsData.app_info.version) {
99102
breadcrumbs.push({
100103
to: makeReleasesUrl(project?.id, {
101-
version: buildDetailsData.app_info.version ?? undefined,
104+
version: buildDetailsData.app_info.version,
102105
appId: buildDetailsData.app_info.app_id ?? undefined,
103106
}),
104107
label: buildDetailsData.app_info.version,
@@ -115,13 +118,19 @@ export function BuildDetailsHeaderContent(props: BuildDetailsHeaderContentProps)
115118
isSentryEmployee,
116119
});
117120

121+
const version = `v${buildDetailsData.app_info.version ?? 'Unknown'} (${buildDetailsData.app_info.build_number ?? 'Unknown'})`;
122+
118123
return (
119-
<Flex direction="column" padding="0 0 xl 0">
120-
<Breadcrumbs crumbs={breadcrumbs} />
121-
<Flex align="center" justify="between" gap="md">
122-
<Heading as="h1">
123-
v{buildDetailsData.app_info.version} ({buildDetailsData.app_info.build_number})
124-
</Heading>
124+
<React.Fragment>
125+
<Layout.HeaderContent>
126+
<Breadcrumbs crumbs={breadcrumbs} />
127+
<Layout.Title>
128+
{project && <IdBadge project={project} avatarSize={28} hideName />}
129+
<Version version={version} anchor={false} truncate />
130+
</Layout.Title>
131+
</Layout.HeaderContent>
132+
133+
<Layout.HeaderActions>
125134
<Flex align="center" gap="sm" flexShrink={0}>
126135
<Link
127136
to={`/organizations/${organization.slug}/preprod/${projectId}/compare/${buildDetailsData.id}/`}
@@ -145,7 +154,7 @@ export function BuildDetailsHeaderContent(props: BuildDetailsHeaderContentProps)
145154
)}
146155
/>
147156
</Flex>
148-
</Flex>
149-
</Flex>
157+
</Layout.HeaderActions>
158+
</React.Fragment>
150159
);
151160
}

0 commit comments

Comments
 (0)