-
-
Notifications
You must be signed in to change notification settings - Fork 354
chore(dep): fix expo sample version to 52.0.19 #4592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note that the type test failures are fixed by #4587 |
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 71f7309 | 412.45 ms | 431.62 ms | 19.18 ms |
| e54b1ed | 434.79 ms | 429.52 ms | -5.27 ms |
| 345e497 | 397.98 ms | 423.40 ms | 25.42 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 71f7309 | 17.75 MiB | 20.10 MiB | 2.36 MiB |
| e54b1ed | 17.75 MiB | 20.10 MiB | 2.36 MiB |
| 345e497 | 17.75 MiB | 20.10 MiB | 2.36 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e54b1ed+dirty | 1227.33 ms | 1254.46 ms | 27.14 ms |
| 345e497+dirty | 1218.83 ms | 1218.73 ms | -0.10 ms |
| 71f7309+dirty | 1222.02 ms | 1224.81 ms | 2.79 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e54b1ed+dirty | 2.63 MiB | 3.68 MiB | 1.05 MiB |
| 345e497+dirty | 2.63 MiB | 3.68 MiB | 1.05 MiB |
| 71f7309+dirty | 2.63 MiB | 3.73 MiB | 1.10 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 345e497+dirty | 375.33 ms | 377.23 ms | 1.90 ms |
| 71f7309+dirty | 361.15 ms | 369.90 ms | 8.75 ms |
| e54b1ed+dirty | 435.06 ms | 429.19 ms | -5.87 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 345e497+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| 71f7309+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
| e54b1ed+dirty | 7.15 MiB | 8.37 MiB | 1.22 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e54b1ed+dirty | 1227.90 ms | 1230.92 ms | 3.02 ms |
| 345e497+dirty | 1210.67 ms | 1207.50 ms | -3.17 ms |
| 71f7309+dirty | 1206.00 ms | 1214.28 ms | 8.28 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e54b1ed+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| 345e497+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| 71f7309+dirty | 3.19 MiB | 4.30 MiB | 1.11 MiB |
krystofwoldrich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Thank you.
When have we updated to 52.0.37 as this is not an issue on main at the moment?
|
I see it's coming from #4568 We should check the yarn.lock changes, there should not be so many changes. |
|
Closing as per #4592 (comment) |
📢 Type of change
Based on #4568
📜 Description
Fixes Expo sample version to
52.0.19to avoid Expo sample Kotlin Version build failure.💡 Motivation and Context
Ci failures
💚 How did you test it?
Manual, CI
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog