ref: rename DisabledSentryStructuredLogger to NoOpSentryStructuredLogger

Author: Flash0ver

src/Sentry/Extensibility/DisabledHub.cs

@@ -260,5 +260,5 @@ public void CaptureUserFeedback(UserFeedback userFeedback)
     /// <para>This API is experimental and it may change in the future.</para>
     /// </summary>
     [Experimental(Infrastructure.DiagnosticId.ExperimentalFeature)]
-    public SentryStructuredLogger Logger => DisabledSentryStructuredLogger.Instance;
+    public SentryStructuredLogger Logger => NoOpSentryStructuredLogger.Instance;
 }

src/Sentry/Internal/DisabledSentryStructuredLogger.cs

@@ -0,0 +1,15 @@
+namespace Sentry.Internal;
+
+internal sealed class NoOpSentryStructuredLogger : SentryStructuredLogger
+{
+    internal static NoOpSentryStructuredLogger Instance { get; } = new NoOpSentryStructuredLogger();
+
+    private NoOpSentryStructuredLogger()
+    {
+    }
+
+    private protected override void CaptureLog(SentryLogLevel level, string template, object[]? parameters, Action<SentryLog>? configureLog)
+    {
+        // disabled
+    }
+}

src/Sentry/Internal/NoOpSentryStructuredLogger.cs

@@ -14,7 +14,7 @@ internal static SentryStructuredLogger Create(IHub hub, IInternalScopeManager sc
     {
         return options.Experimental.EnableLogs
             ? new DefaultSentryStructuredLogger(hub, scopeManager, options, clock)
-            : DisabledSentryStructuredLogger.Instance;
+            : NoOpSentryStructuredLogger.Instance;
     }
 
     private protected SentryStructuredLogger()

src/Sentry/SentryStructuredLogger.cs

@@ -38,5 +38,5 @@ public void CaptureEvent_EmptyGuid()
 
     [Fact]
     public void Logger_IsDisabled()
-        => Assert.IsType<DisabledSentryStructuredLogger>(DisabledHub.Instance.Logger);
+        => Assert.IsType<NoOpSentryStructuredLogger>(DisabledHub.Instance.Logger);
 }

test/Sentry.Tests/Extensibility/DisabledHubTests.cs

@@ -1435,7 +1435,7 @@ public void Logger_IsDisabled_DoesNotCaptureLog()
                 envelope.Items.Single(item => item.Header["type"].Equals("log")).Payload.GetType().IsAssignableFrom(typeof(JsonSerializable))
             )
         );
-        hub.Logger.Should().BeOfType<DisabledSentryStructuredLogger>();
+        hub.Logger.Should().BeOfType<NoOpSentryStructuredLogger>();
     }
 
     [Fact]
@@ -1468,7 +1468,7 @@ public void Logger_EnableAfterCreate_HasNoEffect()
         _fixture.Options.Experimental.EnableLogs = true;
 
         // Assert
-        hub.Logger.Should().BeOfType<DisabledSentryStructuredLogger>();
+        hub.Logger.Should().BeOfType<NoOpSentryStructuredLogger>();
     }
 
     [Fact]

test/Sentry.Tests/HubTests.cs

@@ -78,7 +78,7 @@ public void Create_Disabled_CachedDisabledInstance()
         var instance = _fixture.GetSut();
         var other = _fixture.GetSut();
 
-        instance.Should().BeOfType<DisabledSentryStructuredLogger>();
+        instance.Should().BeOfType<NoOpSentryStructuredLogger>();
         instance.Should().BeSameAs(other);
     }