Skip to content

Commit 22a607b

Browse files
Ermaboclaude
andcommitted
Revert "fix(OpenTelemetry): capture span filter decision eagerly"
This reverts commit 0ec4953. The eager snapshot read IsAllDataRequested/Recorded in OnStart, which runs before OTel instrumentation filters (e.g. HttpClient Filter) clear those flags, so filtered spans were captured as unfiltered. That traded a minor GC-timing edge for a worse late-filtering regression. Back to reading the flags lazily from the weakly-fused Activity. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 0ec4953 commit 22a607b

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

‎src/Sentry.OpenTelemetry/SentrySpanProcessor.cs‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -141,11 +141,8 @@ private void CreateChildSpan(Activity data, ISpan parentSpan, SpanId? parentSpan
141141
{
142142
spanTracer.Origin = OpenTelemetryOrigin;
143143
spanTracer.StartTimestamp = data.StartTimeUtc;
144-
// Capture the sampling decision now; it is fixed at span creation. Reading it lazily from the
145-
// fused Activity would fail once the Activity has been garbage-collected (weak ref returns null),
146-
// causing a filtered span to be included in the transaction instead of dropped.
147-
var isFiltered = data is { IsAllDataRequested: false, Recorded: false };
148-
spanTracer.IsFiltered = () => isFiltered;
144+
// Used to filter out spans that are not recorded when finishing a transaction.
145+
spanTracer.IsFiltered = () => GetFusedActivity(spanTracer) is { IsAllDataRequested: false, Recorded: false };
149146
}
150147
_map[data.SpanId] = span;
151148
}

0 commit comments

Comments
 (0)