Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,9 @@ class IntentGroupTest {
}

private fun assertFileWidgetWithoutAnswer() {
onView(withTagValue(Matchers.`is`("ArbitraryFileWidgetAnswer")))
.check(matches(CoreMatchers.not(isDisplayed())))
composeRule
.onNodeWithClickLabel(ApplicationProvider.getApplicationContext<Application>().getString(R.string.open_file))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add an overload for onNodeWithClickLabel that takes a @StringRes Integer to avoid this noise in the tests?

.assertDoesNotExist()
}

private fun assertImageWidgetWithAnswer() {
Expand Down Expand Up @@ -329,9 +330,9 @@ class IntentGroupTest {
}

private fun assertFileWidgetWithAnswer() {
onView(withTagValue(Matchers.`is`("ArbitraryFileWidgetAnswer")))
.perform(scrollTo())
.check(matches(isDisplayed()))
composeRule
.onNodeWithClickLabel(ApplicationProvider.getApplicationContext<Application>().getString(R.string.open_file))
.assertExists()
}

@Throws(IOException::class)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -188,8 +188,7 @@ public ODKView(
new FileRequesterImpl(intentLauncher, externalAppIntentProvider, formController),
new StringRequesterImpl(intentLauncher, externalAppIntentProvider, formController),
formController,
(FormFillingActivity) context,
settingsProvider
(FormFillingActivity) context
);

widgets = new ArrayList<>();
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading