-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Improve media displayed in widgets [BarcodeWidget + ArbitraryFileWidget + ExArbitraryFileWidget] #6964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grzesiek2010
wants to merge
18
commits into
getodk:master
Choose a base branch
from
grzesiek2010:COLLECT-6234_barcode2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve media displayed in widgets [BarcodeWidget + ArbitraryFileWidget + ExArbitraryFileWidget] #6964
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c0a7841
Rework Barcode widget with Jetpack Compose
grzesiek2010 8237729
Move barcode code to one package
grzesiek2010 6f71d09
Rework BarcodeWidgetTest
grzesiek2010 77029f8
Remove unused code
grzesiek2010 5c77f7b
Fix imports
grzesiek2010 f28d59b
Rework ArbitraryFileWidget with Jetpack Compose
grzesiek2010 cc59cbe
Rework ExArbitraryFileWidget with Jetpack Compose
grzesiek2010 59c10a1
Move classes to one package
grzesiek2010 fb255fe
Rework tests
grzesiek2010 cd08964
Remove unused files
grzesiek2010 703b497
Fix IntentGroupTest
grzesiek2010 f43d7f3
Fix click label
grzesiek2010 70ed2ec
Extract duplicate code to ArbitraryFileWidgetDelegate
grzesiek2010 1e58c97
Extract shared TextWidgetAnswer
grzesiek2010 bc27483
Fix tests
grzesiek2010 c4d4e48
Update text style to match the one used earlier
grzesiek2010 2ab8de9
Update icon color to match text color
grzesiek2010 ed1b344
Use TextWidgetAnswer in WidgetAnswer for not specyfied question types
grzesiek2010 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 0 additions & 89 deletions
89
collect_app/src/main/java/org/odk/collect/android/widgets/ArbitraryFileWidget.kt
This file was deleted.
Oops, something went wrong.
25 changes: 0 additions & 25 deletions
25
collect_app/src/main/java/org/odk/collect/android/widgets/ArbitraryFileWidgetAnswerView.kt
This file was deleted.
Oops, something went wrong.
25 changes: 0 additions & 25 deletions
25
collect_app/src/main/java/org/odk/collect/android/widgets/BarcodeWidgetAnswerView.kt
This file was deleted.
Oops, something went wrong.
68 changes: 0 additions & 68 deletions
68
collect_app/src/main/java/org/odk/collect/android/widgets/BaseArbitraryFileWidget.kt
This file was deleted.
Oops, something went wrong.
91 changes: 0 additions & 91 deletions
91
collect_app/src/main/java/org/odk/collect/android/widgets/ExArbitraryFileWidget.kt
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could add an overload for
onNodeWithClickLabelthat takes a@StringRes Integerto avoid this noise in the tests?