Skip to content

feat: Update substrate v1.4.0#3934

Merged
breathx merged 23 commits into
masterfrom
vs/substrate-v1.4.0
Jul 10, 2024
Merged

feat: Update substrate v1.4.0#3934
breathx merged 23 commits into
masterfrom
vs/substrate-v1.4.0

Conversation

@breathx
Copy link
Copy Markdown
Member

breathx commented May 13, 2024

Please, rebase, cleanup and mention attached migrations in description

@ukint-vs ukint-vs force-pushed the vs/substrate-v1.4.0 branch from 0bf7b7c to 26a04b2 Compare May 15, 2024 12:13
Copy link
Copy Markdown
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes just for avoiding misclick and merge
The PR requires @ekovalev's deep review

Copy link
Copy Markdown
Contributor

@ekovalev ekovalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Authorship part looks cleaner than before.

Comment thread runtime/vara/src/lib.rs
Comment thread node/authorship/src/tests.rs
@breathx
Copy link
Copy Markdown
Member

breathx commented May 26, 2024

Well done!

Please, don't merge it atm to make sure smooth delivery. Also needs to resolve master branch conflicts and leave here a comment about CI migrations (I remember it was discussed personally, but better to post it)

@breathx
Copy link
Copy Markdown
Member

breathx commented Jul 7, 2024

Actualise branch and resolve opened discussions, please @ukint-vs

@breathx breathx merged commit b90deda into master Jul 10, 2024
@breathx breathx deleted the vs/substrate-v1.4.0 branch July 10, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants