-
Notifications
You must be signed in to change notification settings - Fork 11
add models for lattice #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new Sequence diagram for simulating the MZI latticesequenceDiagram
participant circuit_lattice.py
participant cells.mzi_lattice
participant PDK.models
participant sax.circuit
participant circuit
circuit_lattice.py->>cells.mzi_lattice: cells.mzi_lattice(delta_length=10)
circuit_lattice.py->>PDK.models: models = PDK.models
circuit_lattice.py->>sax.circuit: circuit, _ = sax.circuit(netlist, models=models)
circuit_lattice.py->>circuit: S = circuit(wl=wl)
Class diagram for the new mzi_lattice_sc cellclassDiagram
class mzi_lattice_sc{
+delta_length: float
+bend: str
+straight: str
+splitter: str
+combiner: str
+cross_section: CrossSectionSpec
+gf.Component mzi_lattice_sc()
}
note for mzi_lattice_sc "New cell for creating MZI lattices"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
Summary by Sourcery
Adds a new
mzi_lattice_sccell and a corresponding example script for circuit simulation. Updates coupler models.New Features:
mzi_lattice_sccell, a Mach-Zehnder interferometer lattice structure, to thecspdk.si220.cells.primitivesmodule.circuit_lattice.py, to demonstrate circuit simulation of themzi_lattice_sccell.