Add Action for validating package.xml files#70
Merged
Conversation
added 8 commits
April 5, 2024 16:46
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
scpeters
reviewed
Apr 9, 2024
Signed-off-by: Addisu Z. Taddese <[email protected]>
scpeters
approved these changes
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the conversation in gazebosim/gz-cmake#413 (comment), this adds an Action that can be used in all of our Harmonic packages to check that the versions in CMake and package.xml are consistent.
See usage in gazebosim/gz-cmake#413
I'm adding this to the
jammybranch, but I'm open to using a different branch. I think we can actually consolidate thefocal,jammy, and nownoblebranches into one branch with different directories for each version. We might even be able to consolidate the actions so we don't need three different versions. But for now, I thought the easiest thing was to add it to the branch we mostly use in Harmonic branches.