fix(gatsby): add mjs config to webpack and resolve correctly #8717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Didn't you do that here with the |
Contributor
Author
yeah, i meant that the previous prs was half the solution |
DSchau
approved these changes
Oct 2, 2018
Contributor
DSchau
left a comment
DSchau
left a comment
There was a problem hiding this comment.
Alright! This looks good now :) I added a few tests and validated with the repro in the issue, as well as tracked regressions with a default starter.
Let's wait for the tests to pass, and then we can get this merged in!
DSchau
changed the title
.mjs files are to be load…
Contributor
|
lipis
added a commit
to lipis/gatsby
that referenced
this pull request
Oct 3, 2018
* 'master' of github.com:gatsbyjs/gatsby: (72 commits) fix: fix wording in plopfile (gatsbyjs#8735) fix: navigateTo deprecation message (gatsbyjs#8745) Add deploying-to-heroku.md (gatsbyjs#8721) fix(docs): Link to instructions on adding to plugin library (gatsbyjs#8686) updated gatsby-plugin-remove-trailing-slashes docs to include link re… (gatsbyjs#8720) feat(www/starters): Add TypeScript and Contentful starter (gatsbyjs#8704) fix(docs): fix typos in template doc (gatsbyjs#8692) feat(www): change chevron direction on sticky responsive sidebar (gatsbyjs#8664) chore(release): Publish [integration] [cypress-gatsby] feat: Add Gatsby API support to our Cypress plugin (gatsbyjs#8641) chore(release): Publish fix(gatsby): add mjs config to webpack and resolve correctly (gatsbyjs#8717) feat(gatsby-plugin-netlify): add force option to createRedirect (gatsbyjs#8521) [www/starters] tweaks to fix DX for no GH token on www (gatsbyjs#8718) chore(release): Publish fix(gatsby-dev-cli): infer correct prefix from package path (gatsbyjs#8683) fix(www/starters): fix broken link to submission instructions (gatsbyjs#8715) chore(release): Publish feat(gatsby) : add createContentDigest helper (gatsbyjs#8687) feat: publish SendGrid case study blogpost (gatsbyjs#8592) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deals with issues:
.mjsissues after the switch to webpack 4Add webpack rule to explicitly state that
.mjsfiles are to be loaded in with the default webpack 4 js loader. Comments also left for future references.@KyleAMathews 's pr (https://github.com/gatsbyjs/gatsby/pull/8327/files) was correct to add the extensions -- but
.mjsneeds to be before the.jsextension. Looks like someone changed it in a PR afterwards. In any case, this is half of the solution. We need to explicitly state what loader webpack should use when resolving these files.