cache-dir/loader.js cleanup #6017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevents creating multiple requests for same file
Collaborator
|
Deploy preview for using-drupal ready! Built with commit 341f6d5 |
Collaborator
|
Deploy preview for gatsbygram ready! Built with commit 341f6d5 |
Contributor
|
👍 |
KyleAMathews
pushed a commit
that referenced
this pull request
Jun 21, 2018
* cleanup duplicated getResourceModule calls in loader.js * instead of storing just result of fetching json data, store promise prevents creating multiple requests for same file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit cleans up what seems to be code from master merge that shouldn't be there - it would try to fetch resources if they were already fetched and stored in
pathScriptsCachemap)Second commit makes sure to not try to fetch same
.jsonfile multiple timesIssues this PR fixes were mentioned in #5109 (comment)