Skip to content

fix(gatsby): createNode return promise #34399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2022
Merged

fix(gatsby): createNode return promise #34399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1604a05
always return a promise from createNode
TylerBarnes Jan 4, 2022
50223e4
protect against versions of gatsby that might not return a promise fr…
TylerBarnes Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/gatsby-source-contentful/src/normalize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,7 +763,12 @@ export const createAssetNodes = ({
// The content of an entry is guaranteed to be updated if and only if the .sys.updatedAt field changed
assetNode.internal.contentDigest = assetItem.sys.updatedAt

createNodePromises.push(createNode(assetNode).then(() => assetNode))
// if the node hasn't changed, createNode may return `undefined` instead of a Promise on some versions of Gatsby
const maybePromise = createNode(assetNode)

createNodePromises.push(
maybePromise?.then ? maybePromise.then(() => assetNode) : assetNode
)
})

return createNodePromises
Expand Down
2 changes: 1 addition & 1 deletion packages/gatsby/src/redux/actions/public.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,7 @@ actions.createNode =
).find(action => action.type === `CREATE_NODE`)

if (!createNodeAction) {
return undefined
return Promise.resolve(undefined)
}

const { payload: node, traceId, parentSpan } = createNodeAction
Expand Down