Skip to content

Conversation

@vladar
Copy link
Contributor

@vladar vladar commented Jun 1, 2021

Description

When merging abstract types Gatsby should also merge resolveType when it is available. Otherwise, users may see an error like this one:

image

Thanks to @andris-sevcenko for reporting this.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 1, 2021
@vladar vladar added topic: GraphQL Related to Gatsby's GraphQL layer and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 1, 2021
@vladar vladar merged commit 2dde956 into master Jun 1, 2021
@vladar vladar deleted the vladar/fix-resolvetype-merging branch June 1, 2021 12:48
moonmeister added a commit to moonmeister/gatsby that referenced this pull request Jun 1, 2021
* master: (23 commits)
  fix(gatsby-source-wordpress): Prevent "EADDRINUSE: address already in use 127.0.0.1" error (gatsbyjs#31713)
  feat(gatsby-source-wordpress: architecture.md (gatsbyjs#31537)
  chore(deps): update dependency @babel/node to ^7.14.2 (gatsbyjs#31690)
  chore(deps): update babel monorepo (gatsbyjs#31143)
  fix(gatsby): merge resolveType when merging abstract types (gatsbyjs#31710)
  chore(release): Publish next
  fix(gatsby): Correct config for svgo plugins whitelist
  chore: Add translations and validations to Contentful test (gatsbyjs#31533)
  chore(docs): Correct nginx spelling (gatsbyjs#31651)
  chore(docs): Update Jest instructions for v27 (gatsbyjs#31649)
  Fix typo in adding-search.md (gatsbyjs#31639)
  Fix typos in improving-build-performance.md (gatsbyjs#31640)
  feat(gatsby-source-wordpress): Fix false positive error if the URL and the responsePath are the same (gatsbyjs#31612)
  Fixed syntax error in example (gatsbyjs#31636)
  fix(contentful): pass reporter to retry function (gatsbyjs#31608)
  chore: Properly typecheck `gatsby` (gatsbyjs#31519)
  fix(gatsby-source-contentful): fix progress bar (gatsbyjs#31467)
  fix(gatsby-plugin-gatsby-cloud): fix cloud being bundled (gatsbyjs#31604)
  chore(gatsby-source-wordpress): Fix typos (gatsbyjs#31600)
  chore(docs): Add title to release notes (gatsbyjs#31595)
  ...
LekoArts pushed a commit that referenced this pull request Jun 2, 2021
LekoArts pushed a commit that referenced this pull request Jun 2, 2021
@LekoArts
Copy link
Contributor

LekoArts commented Jun 2, 2021

Published in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: GraphQL Related to Gatsby's GraphQL layer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants