chore: Properly typecheck gatsby
#31519
Conversation
LekoArts
added
the
topic: TypeScript
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
| } | ||
|
|
||
| function DiskStore(options): void { | ||
| function DiskStore(this: any, options): void { |
There was a problem hiding this comment.
Fixes TS2683: 'this' implicitly has type 'any' because it does not have a type annotation. throughout the file
There was a problem hiding this comment.
TIL: about typing this as first param :O
|
|
||
| // node env should be DEVELOPMENT | PRODUCTION as these are commonly used in node land | ||
| const nodeEnv = process.env.NODE_ENV || `${defaultNodeEnv}` | ||
| const nodeEnv = process.env.NODE_ENV || `development` |
There was a problem hiding this comment.
defaultNodeEnv wasn't set
There was a problem hiding this comment.
I think I copy/pasted that from webpack.config.js and that didn't get changed
| ) | ||
| buildSSRBundleActivityProgress.start() | ||
| let pageRenderer: string | ||
| let pageRenderer = `` |
There was a problem hiding this comment.
"Used before initialized error" - setting a default here will also assign it string
| } from "cache-manager" | ||
| import fs from "fs-extra" | ||
| import fsStore from "../cache/cache-fs" | ||
| import * as fsStore from "../cache/cache-fs" |
There was a problem hiding this comment.
Complained about "default export not existing"
KyleAMathews
left a comment
KyleAMathews
left a comment
There was a problem hiding this comment.
👍 to functions changes! Thanks for finding this & all the cleanups 🚀
| } | ||
|
|
||
| function DiskStore(options): void { | ||
| function DiskStore(this: any, options): void { |
There was a problem hiding this comment.
Isn't this equal to DiskStore? (I'm also new to this in typescript 😂)
There was a problem hiding this comment.
So this was about having it implicitly:
TS2683: 'this' implicitly has type 'any' because it does not have a type annotation.
I didn't want to type everything so this is the best middleground for now
| // eslint-disable-next-line @babel/no-invalid-this | ||
| const promise = fn.apply(this, args) | ||
| // @ts-ignore - unsure if fixing this introduces problems | ||
| const promise = fn.apply(this, args) // eslint-disable-line @babel/no-invalid-this |
There was a problem hiding this comment.
wouldn't eslint-disable-next-line still work because next line is also a comment?
There was a problem hiding this comment.
No, it didn't work for me so I had to move it :/
| join(`page-data`, `sq`, `d`, `${hash}.json`) | ||
|
|
||
| const getStaticQueryResult = async (hash: string): any => { | ||
| const getStaticQueryResult = async (hash: string): Promise<any> => { |
There was a problem hiding this comment.
This is not really any but we didn't type it before either so 👍
* master: (23 commits) fix(gatsby-source-wordpress): Prevent "EADDRINUSE: address already in use 127.0.0.1" error (gatsbyjs#31713) feat(gatsby-source-wordpress: architecture.md (gatsbyjs#31537) chore(deps): update dependency @babel/node to ^7.14.2 (gatsbyjs#31690) chore(deps): update babel monorepo (gatsbyjs#31143) fix(gatsby): merge resolveType when merging abstract types (gatsbyjs#31710) chore(release): Publish next fix(gatsby): Correct config for svgo plugins whitelist chore: Add translations and validations to Contentful test (gatsbyjs#31533) chore(docs): Correct nginx spelling (gatsbyjs#31651) chore(docs): Update Jest instructions for v27 (gatsbyjs#31649) Fix typo in adding-search.md (gatsbyjs#31639) Fix typos in improving-build-performance.md (gatsbyjs#31640) feat(gatsby-source-wordpress): Fix false positive error if the URL and the responsePath are the same (gatsbyjs#31612) Fixed syntax error in example (gatsbyjs#31636) fix(contentful): pass reporter to retry function (gatsbyjs#31608) chore: Properly typecheck `gatsby` (gatsbyjs#31519) fix(gatsby-source-contentful): fix progress bar (gatsbyjs#31467) fix(gatsby-plugin-gatsby-cloud): fix cloud being bundled (gatsbyjs#31604) chore(gatsby-source-wordpress): Fix typos (gatsbyjs#31600) chore(docs): Add title to release notes (gatsbyjs#31595) ...
Co-authored-by: Kyle Mathews <[email protected]>
Description
We had the wrong
tsconfig.json🙈 Only the exports/files included insrc/internal.tswere typechecked[ch31613]