fix(gatsby-plugin-manifest): Fix or Joi assertion
#29242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: plugins-PWA
wardpeet
previously approved these changes
Jan 28, 2021
wardpeet
added
the
bot: merge on green
wardpeet
approved these changes
Jan 28, 2021
This was referenced Mar 9, 2021
chore(deps-dev): bump gatsby-plugin-manifest from 2.10.0 to 3.0.0
looker-open-source/components#2040
Closed
This was referenced Mar 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #29112 (comment)
According to the docs with
oralready one of the two is required:So having
required()on both of them leads to the error that it's still required.