fix(gatsby-plugin-image): Correct image styles #28834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
added
topic: media
pvdz
previously approved these changes
Jan 4, 2021
Contributor
pvdz
left a comment
pvdz
left a comment
There was a problem hiding this comment.
The in and delete patterns are really red flags for me. But I mean, it's valid code and not in a perf sensitive path so I'll leave it up to you :)
packages/gatsby-plugin-image/src/components/gatsby-image.browser.tsx
Outdated
Show resolved
Hide resolved
packages/gatsby-plugin-image/src/components/gatsby-image.server.tsx
Outdated
Show resolved
Hide resolved
pvdz
approved these changes
Jan 4, 2021
ascorbic
added
the
bot: merge on green
vladar
pushed a commit
that referenced
this pull request
Jan 5, 2021
* fix(gatsby-plugin-image): Correct image styles * Remove avif options from dom * Remove in/delete (cherry picked from commit 3d6446c)
gatsbybot
pushed a commit
that referenced
this pull request
Jan 5, 2021
* fix(gatsby-plugin-image): Correct image styles * Remove avif options from dom * Remove in/delete (cherry picked from commit 3d6446c) Co-authored-by: Matt Kane <[email protected]>
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two bugfixes to the handling of styles in gatsby-plugin-image. First, it correctly applies some styles that were msising in SSR. Second it fixes a compatibility issue when using preact, where the "class" prop was not intercepted, and was instead passed-down to the img tag. The same would happen if using the class prop in React (instead of className), but it less of an issue as that's not explicitly allowed (though does normally work).
Fixes bug reported in #27950 (comment)