Skip to content

chore: update react-dev-utils, react-error-overlay #26697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

chore: update react-dev-utils, react-error-overlay #26697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03e6269
Update packages
herecydev Aug 29, 2020
8cb8a9b
Remove unused formatting
herecydev Aug 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/gatsby/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@
"prop-types": "^15.7.2",
"query-string": "^6.13.1",
"raw-loader": "^0.5.1",
"react-dev-utils": "^4.2.3",
"react-error-overlay": "^3.0.0",
"react-dev-utils": "^10.2.1",
"react-error-overlay": "^6.0.7",
"react-hot-loader": "^4.12.21",
"react-refresh": "^0.7.0",
"redux": "^4.0.5",
Expand Down
7 changes: 1 addition & 6 deletions packages/gatsby/src/services/start-webpack-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import openurl from "better-opn"
import report from "gatsby-cli/lib/reporter"
import formatWebpackMessages from "react-dev-utils/formatWebpackMessages"
import chalk from "chalk"
import { Compiler } from "webpack"
import { isEqual } from "lodash"
Expand Down Expand Up @@ -79,16 +78,12 @@ export async function startWebpackServer({
// "done" event fires when Webpack has finished recompiling the bundle.
// Whether or not you have warnings or errors, you will get this event.

// We have switched off the default Webpack output in WebpackDevServer
// options so we are going to "massage" the warnings and errors and present
// them in a readable focused way.
const messages = formatWebpackMessages(stats.toJson({}, true))
const urls = prepareUrls(
program.https ? `https` : `http`,
program.host,
program.proxyPort
)
const isSuccessful = !messages.errors.length
const isSuccessful = !stats.toJson({}, true).errors.length

if (isSuccessful && isFirstCompile) {
printInstructions(
Expand Down
Loading