Skip to content

Conversation

@ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Mar 1, 2021

Backport #29813 to 2.32 release
(cherry picked from commit 28124dd)

Co-authored-by: Ward Peeters <[email protected]>
(cherry picked from commit 28124dd)
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 1, 2021
@ascorbic ascorbic added type: cherry and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 1, 2021
@ascorbic ascorbic requested a review from TylerBarnes March 1, 2021 16:36
Copy link
Contributor

@TylerBarnes TylerBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @ascorbic ! We also need this commit a9b139c (#29813)

@ascorbic
Copy link
Contributor Author

ascorbic commented Mar 1, 2021

@TylerBarnes The line it's changing doesn't exist in this branch

Copy link
Contributor

@TylerBarnes TylerBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad 👍 I had another look and you're right it shouldn't be in here. Thanks again @ascorbic !

@pieh pieh merged commit c7a6e9f into release/2.32 Mar 4, 2021
@pieh pieh deleted the backport-2.32-29813 branch March 4, 2021 16:39
This was referenced Mar 9, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants