feat(gatsby-core-utils): Add file download functions - #29531
Merged
Conversation
gatsbot
Bot
added
the
status: triage needed
ascorbic
force-pushed
the
chore/move-file-functions
branch
from
February 16, 2021 10:16
32d4d43 to
bea141d
Compare
ascorbic
added
topic: media
ascorbic
marked this pull request as ready for review
February 16, 2021 11:02
laurieontech
left a comment
laurieontech
left a comment
Contributor
There was a problem hiding this comment.
Does this solve the issue entirely though? We use both remoteFileNode and createFileNode. This appears to only move the former out of gatsby-source-filesystem?
Contributor
Author
|
The idea would be that we stop creating file nodes, and just download the file |
wardpeet
reviewed
Feb 18, 2021
wardpeet
reviewed
Feb 18, 2021
wardpeet
left a comment
wardpeet
left a comment
Contributor
There was a problem hiding this comment.
This looks good! This is going to be helpful for other plugins as well. Can you port some tests over?
ascorbic
added
the
bot: merge on green
ascorbic
removed
the
bot: merge on green
This was referenced Mar 12, 2021
Merged
This was referenced Mar 17, 2021
Merged
Closed
Merged
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
* feat(gatsby-core-utils): Add file download functions * skiplibcheck * Export interface * Port tests * Fix type Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
raffishquartan
pushed a commit
to raffishquartan/gatsby
that referenced
this pull request
Apr 28, 2026
* feat(gatsby-core-utils): Add file download functions * skiplibcheck * Export interface * Port tests * Fix type Co-authored-by: gatsbybot <mathews.kyle+gatsbybot@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the file download function
fetchRemoteNodeto gatsby-core-utils and rename it tofetchRemoteFile