fix(gatsby-source-filesystem): Support creating file nodes for paths containing folders - #25687
Merged
pieh merged 1 commit intoJul 16, 2020
Merged
Conversation
…containing folders
pieh
approved these changes
Jul 16, 2020
pieh
left a comment
Contributor
There was a problem hiding this comment.
Yup, makes sense. Thanks for handling it!
|
Holy buckets, @jshearer — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
…containing folders (gatsbyjs#25687)
raffishquartan
pushed a commit
to raffishquartan/gatsby
that referenced
this pull request
Apr 28, 2026
…containing folders (gatsbyjs#25687)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I encountered a subtile bug in the logic for handling
createFileNodeFromBuffer. My intention is to create file nodes nested inside folders. When I try this currently (without this PR), the containing folder hierarchy is not created, since the call tofs.ensureDiris passed a different directory thanwriteBuffer. This PR fixes that.Documentation
The docs for
createFileNodeFromBufferare here.Related Issues
There are no related issues that I could find.