Skip to content

fix(gatsby-source-filesystem): Move GraphQL definition for File into sourceNodes - #16041

Merged
sidharthachatterjee merged 2 commits into
gatsbyjs:masterfrom
stefanprobst:filesystem-bump-peer-deps
Jul 30, 2019
Merged

fix(gatsby-source-filesystem): Move GraphQL definition for File into sourceNodes#16041
sidharthachatterjee merged 2 commits into
gatsbyjs:masterfrom
stefanprobst:filesystem-bump-peer-deps

Conversation

@stefanprobst

Copy link
Copy Markdown
Contributor

Since #15409 gatsby-source-filesystem uses the createSchemaCustomization API, which is only available in Gatsby ^2.12, so we should bump the peer deps.

Fixes #15680

@stefanprobst
stefanprobst requested a review from a team July 24, 2019 09:38
@stefanprobst stefanprobst changed the title Bump peer deps chore(gatsby-source-filesystem): Bump peer deps Jul 24, 2019
@sidharthachatterjee

sidharthachatterjee commented Jul 24, 2019

Copy link
Copy Markdown
Contributor

Eh, now I feel like we should move the call to createTypes (from #15409) to sourceNodes for better backwards compatibility

Thoughts @pieh?

@sidharthachatterjee sidharthachatterjee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move to sourceNodes for now and switch back to createSchemaCustomization once we make some progress on #16055

@stefanprobst

stefanprobst commented Jul 24, 2019

Copy link
Copy Markdown
Contributor Author

Moved to sourceNodes. The other option would be to move the type defs for File into core (cf. also here and here)

@sidharthachatterjee sidharthachatterjee changed the title chore(gatsby-source-filesystem): Bump peer deps fix(gatsby-source-filesystem): Move GraphQL definition for File into sourceNodes Jul 30, 2019
@sidharthachatterjee

Copy link
Copy Markdown
Contributor

Yeah, probably makes sense to move into core in the long term. Publishing this for now to solve backwards compatibility for folks.

@sidharthachatterjee
sidharthachatterjee merged commit 36eae6b into gatsbyjs:master Jul 30, 2019
@stefanprobst
stefanprobst deleted the filesystem-bump-peer-deps branch July 31, 2019 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The plugin "gatsby-source-filesystem@2.1.5" is exporting a variable named "createSchemaCustomization" which isn't an API.

2 participants