Skip to content

fix(gatsby-source-filesystem): report when downloading fails - #10980

Merged
pieh merged 3 commits into
gatsbyjs:masterfrom
oorestisime:fix-filesystem-queue-error
Jan 31, 2019
Merged

fix(gatsby-source-filesystem): report when downloading fails#10980
pieh merged 3 commits into
gatsbyjs:masterfrom
oorestisime:fix-filesystem-queue-error

Conversation

@oorestisime

@oorestisime oorestisime commented Jan 10, 2019

Copy link
Copy Markdown
Contributor

Description

While working on #10979 i came across this.
The queue was receiving the error as the result argument.
i Added a warn there in order to avoid failing silently

@oorestisime
oorestisime requested a review from pieh January 27, 2019 20:26
@pieh pieh changed the title Fix queue errors and report when downloading fails fix(gatsby-source-filesystem): report when downloading fails Jan 29, 2019
Comment thread packages/gatsby-source-filesystem/src/create-remote-file-node.js
@pieh

pieh commented Jan 31, 2019

Copy link
Copy Markdown
Contributor

Looking good. In the future we will want to move to use reporter.warn, but this is in general problematic right now because we don't pass reporter to createRemoteFileNode so for now console.warn is fine-ish

@oorestisime

Copy link
Copy Markdown
Contributor Author

should i open an issue for that?

@pieh

pieh commented Jan 31, 2019

Copy link
Copy Markdown
Contributor

@oorestisime We don't have issue for not using console.(log|warn|error) yet, so let's not create issue specifically for it yet.

@pieh
pieh merged commit eff2cf4 into gatsbyjs:master Jan 31, 2019
mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
raffishquartan pushed a commit to raffishquartan/gatsby that referenced this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants