[1.0] Add tests for parsing regex args + fix bug (#1267)

* Add tests for parsing regex args + fix bug

* fix old test

Author: KyleAMathews

packages/gatsby/src/schema/__tests__/__snapshots__/prepare-regex.js.snap

@@ -0,0 +1,7 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`Prepare regex for Sift.js handles flags regex 1`] = `/blue/i`;
+
+exports[`Prepare regex for Sift.js handles simple regex 1`] = `/blue/`;
+
+exports[`Prepare regex for Sift.js handles slashes 1`] = `/bl\\\\/ue/i`;

packages/gatsby/src/schema/__tests__/infer-graphql-input-type-test.js

@@ -283,7 +283,7 @@ describe(`GraphQL Input args`, () => {
       nodes,
       `
       {
-            allNode(filter: {name: { regex: "/^the.*wax/i/" }}) {
+            allNode(filter: {name: { regex: "/^the.*wax/i" }}) {
               edges { node { name }}
             }
           }

packages/gatsby/src/schema/__tests__/prepare-regex.js

@@ -0,0 +1,13 @@
+const prepareRegex = require(`../prepare-regex`)
+
+describe(`Prepare regex for Sift.js`, () => {
+  it(`handles simple regex`, () => {
+    expect(prepareRegex(`/blue/`)).toMatchSnapshot()
+  })
+  it(`handles flags regex`, () => {
+    expect(prepareRegex(`/blue/i`)).toMatchSnapshot()
+  })
+  it(`handles slashes`, () => {
+    expect(prepareRegex(`/bl\/ue/i`)).toMatchSnapshot()
+  })
+})

packages/gatsby/src/schema/prepare-regex.js

@@ -0,0 +1,7 @@
+const _ = require(`lodash`)
+
+module.exports = str => {
+  const exploded = str.split(`/`)
+  const regex = new RegExp(exploded.slice(1, -1).join(`/`), _.last(exploded))
+  return regex
+}

packages/gatsby/src/schema/run-sift.js

@@ -4,6 +4,7 @@ const _ = require(`lodash`)
 const { connectionFromArray } = require(`graphql-skip-limit`)
 const { store } = require(`../redux/`)
 const { createPageDependency } = require(`../redux/actions/add-page-dependency`)
+const prepareRegex = require(`./prepare-regex`)
 
 type Node = {
   id: String,
@@ -23,9 +24,7 @@ module.exports = ({ args, nodes, connection = false, path = `` }) => {
       } else {
         // Compile regex first.
         if (k === `regex`) {
-          const exploded = v.split(`/`)
-          const regex = new RegExp(exploded[1], exploded[2])
-          newObject[`$regex`] = regex
+          newObject[`$regex`] = prepareRegex(v)
         } else if (k === `glob`) {
           const Minimatch = require(`minimatch`).Minimatch
           const mm = new Minimatch(v)