Skip to content

Commit a9f7d73

Browse files
committed
REBASE: Comment cleanup
1 parent e789bc4 commit a9f7d73

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

lib/ghomfp.gi

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1234,7 +1234,7 @@ InstallGlobalFunction(ProcessEpimorphismToNewFpGroup,
12341234
function(hom)
12351235
local s,r,fam,fas,fpf,mapi;
12361236
if not (HasIsSurjective(hom) and IsSurjective(hom)) then
1237-
Info(InfoWarning,1,"ill created epimorphismfp");
1237+
Info(InfoWarning,1,"fp eipimorphism is created in strange way, bail out");
12381238
return; # hom might be ill defined.
12391239
fi;
12401240
s:=Source(hom);
@@ -1244,13 +1244,15 @@ local s,r,fam,fas,fpf,mapi;
12441244
return; # the method does not apply here. One could try to deal with the
12451245
#extra generators separately, but that is too much work for what is
12461246
#intended as a minor hint.
1247-
Error("fp generators?");
12481247
fi;
12491248
s:=SubgroupNC(s,mapi[1]);
12501249
fam:=FamilyObj(One(r));
12511250
fas:=FamilyObj(One(s));
12521251
if IsPermCollection(s) or IsMatrixCollection(s)
12531252
or IsPcGroup(s) or CanEasilyCompareElements(s) then
1253+
# in the long run this should be the inverse of the source restricted
1254+
# mapping (or the corestricted inverse) but that does not work well with
1255+
# current homomorphism code, thus build new map.
12541256
#fpf:=InverseGeneralMapping(hom);
12551257
fpf:=GroupHomomorphismByImagesNC(r,s,mapi[2],mapi[1]);
12561258
elif IsFpGroup(s) and HasFPFaithHom(fas) then

0 commit comments

Comments
 (0)