Skip to content

Commit 41fd71a

Browse files
committed
Require setup-gap@v3 to simplify some code
1 parent 142daa5 commit 41fd71a

File tree

3 files changed

+4
-22
lines changed

3 files changed

+4
-22
lines changed

.github/workflows/CI.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,7 @@ jobs:
6666
uses: actions/checkout@v6
6767
with:
6868
path: this-action/
69-
- uses: gap-actions/setup-gap@v2
70-
with:
71-
GAP_PKGS_TO_BUILD: ''
69+
- uses: gap-actions/setup-gap@v3
7270
- uses: gap-actions/build-pkg@v2
7371
- uses: ./this-action/
7472
with:
@@ -128,9 +126,7 @@ jobs:
128126
uses: actions/checkout@v6
129127
with:
130128
path: this-action/
131-
- uses: gap-actions/setup-gap@v2
132-
with:
133-
GAP_PKGS_TO_BUILD: ''
129+
- uses: gap-actions/setup-gap@v3
134130
- uses: gap-actions/build-pkg@v2
135131
- uses: ./this-action/
136132
with:

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ All of the following inputs are optional.
3838
### What's new in v4
3939

4040
There are several changes between v3 and v4: the introduction of the `mode` option,
41-
the renaming of some options,
41+
the renaming of some options, the requirement for using `gap-actions/setup-gap@v3` or newer
4242
and the restriction of the allowed values for boolean-like options.
4343

4444
#### Renamed options

action.yml

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -53,20 +53,6 @@ runs:
5353
run: |
5454
set -ex
5555
56-
GAPROOT=${GAPROOT-$HOME/gap}
57-
58-
# set up a custom GAP root containing only this package, so that
59-
# we can force GAP to load the correct version of this package
60-
# (we already did that in build_pkg.sh, but we do it again here,
61-
# to allow the occasional instance where a package wants to also
62-
# run the tests of others packages, by invoking this script multiple
63-
# times in different directories)
64-
mkdir -p /tmp/gaproot/pkg/
65-
ln -f -s $PWD /tmp/gaproot/pkg/
66-
67-
# start GAP with custom GAP root, to ensure correct package version is loaded
68-
GAP="$GAPROOT/gap -l /tmp/gaproot; --quitonbreak"
69-
7056
# Prepend pre-gap prefix, if it exists
7157
if [[ ! -z "${{ inputs.pre-gap }}" ]]; then
7258
GAP="${{ inputs.pre-gap }} $GAP"
@@ -96,7 +82,7 @@ runs:
9682
fi;
9783
9884
SetInfoLevel(InfoPackageLoading, PACKAGE_DEBUG);
99-
SetPackagePath(info.PackageName, "/tmp/gaproot/pkg/$(basename $PWD)");
85+
SetPackagePath(info.PackageName, "$PWD");
10086
10187
# Capture the output of loading
10288
output := "";

0 commit comments

Comments
 (0)