Only use shell to spawn commands when on Windows

Author: fwcd

src/languageSetup.ts

@@ -5,7 +5,7 @@ import * as path from "path";
 import * as vscode from 'vscode';
 import { LanguageClient, LanguageClientOptions, RevealOutputChannelOn, ServerOptions, StreamInfo } from "vscode-languageclient/node";
 import { LOG } from './util/logger';
-import { isOSUnixoid, correctScriptName } from './util/osUtils';
+import { isOSUnixoid, correctScriptName, isOSWindows } from './util/osUtils';
 import { ServerDownloader } from './serverDownloader';
 import { JarClassContentProvider } from "./jarClassContentProvider";
 import { KotlinApi } from "./lspExtensions";
@@ -222,7 +222,7 @@ function createLanguageClient(options: {
             command: options.startScriptPath,
             args: [],
             options: {
-                shell: true,
+                shell: isOSWindows(),
                 cwd: vscode.workspace.workspaceFolders?.[0]?.uri?.fsPath,
                 env: options.env
             } // TODO: Support multi-root workspaces (and improve support for when no available is available)
@@ -248,7 +248,7 @@ export function spawnLanguageServerProcessAndConnectViaTcp(options: {
         // Wait for the first client to connect
         server.listen(options.tcpPort, () => {
             const tcpPort = (server.address() as net.AddressInfo).port.toString();
-            const proc = child_process.spawn(options.startScriptPath, ["--tcpClientPort", tcpPort], { shell: true });
+            const proc = child_process.spawn(options.startScriptPath, ["--tcpClientPort", tcpPort], { shell: isOSWindows() });
             LOG.info("Creating client at {} via TCP port {}", options.startScriptPath, tcpPort);
 
             const outputCallback = data => options.outputChannel.append(`${data}`);