Commit 1d47674
committed
fix: linux-amd64-e2e job timeout issue
Assume etcd-io#16916 as baseline. The E2E takes `1395.082s`.
* etcd-io#16988
It introduced `TestAuthority` which takes `18.39s`.
And after etcd-io#16997, it takes `50.05s`.
* etcd-io#16995
It introduced `TestInPlaceRecovery` which takes `17.37s`.
* etcd-io#17144
- New `TestHTTPHealthHandler` takes `29.9s`
- New `TestHTTPLivezReadyzHandler` takes `35.20s`
* etcd-io#17173
- New `TestMemberReplace` takes `7.55s`.
Ideally, it should increase `140.07s`. It's not larger than `1800s`
timeout value.
However, we run E2E cases 3 times. By default, we run E2E cases with
`-cpu 1,2,4`. That means that we run 3 times.
`1395.082s` + `140.07s * 3` = `1815.292s` > `1800s`
```bash
$ go help testflag
-count n
Run each test, benchmark, and fuzz seed n times (default 1).
If -cpu is set, run n times for each GOMAXPROCS value.
Examples are always run once. -count does not apply to
fuzz tests matched by -fuzz.
```
I don't think we should run E2E with different GOMAXPROCS value. All the
`TestXYZ` are used to control etcd process and we don't set GOMAXPROCS
env to etcd process. So, we don't need `-cpu` setting for E2E.
Closes: etcd-io#17241
Signed-off-by: Wei Fu <[email protected]>1 parent 420669a commit 1d47674
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
340 | 340 | | |
341 | 341 | | |
342 | 342 | | |
343 | | - | |
| 343 | + | |
344 | 344 | | |
345 | 345 | | |
346 | 346 | | |
| |||
0 commit comments