Skip to content

Commit de8eef0

Browse files
Merge pull request Percona-Lab#36 from ikarishinjieva/master
fix: --max-fk-samples was not applied
2 parents 49ba5ff + 9b2abb8 commit de8eef0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

main.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ func main() {
197197
count := *opts.Rows / *opts.BulkSize
198198
remainder := *opts.Rows - count**opts.BulkSize
199199
semaphores := makeSemaphores(*opts.MaxThreads)
200-
rowValues := makeValueFuncs(db, table.Fields)
200+
rowValues := makeValueFuncs(db, table.Fields, *opts.Samples)
201201
log.Debugf("Must run %d bulk inserts having %d rows each", count, *opts.BulkSize)
202202

203203
runInsertFunc := runInsert
@@ -388,7 +388,7 @@ func runInsert(db *sql.DB, insertQuery string, resultsChan chan int, sem chan bo
388388
}
389389

390390
// makeValueFuncs returns an array of functions to generate all the values needed for a single row
391-
func makeValueFuncs(conn *sql.DB, fields []tableparser.Field) insertValues {
391+
func makeValueFuncs(conn *sql.DB, fields []tableparser.Field, samples int64) insertValues {
392392
var values []getter
393393
for _, field := range fields {
394394
if !field.IsNullable && field.ColumnKey == "PRI" && strings.Contains(field.Extra, "auto_increment") {
@@ -398,7 +398,7 @@ func makeValueFuncs(conn *sql.DB, fields []tableparser.Field) insertValues {
398398
samples, err := getSamples(conn, field.Constraint.ReferencedTableSchema,
399399
field.Constraint.ReferencedTableName,
400400
field.Constraint.ReferencedColumnName,
401-
100, field.DataType)
401+
samples, field.DataType)
402402
if err != nil {
403403
log.Printf("cannot get samples for field %q: %s\n", field.ColumnName, err)
404404
continue

0 commit comments

Comments
 (0)