fix: move installer to npx, add proxy matcher, remove curl endpoint (#337)

Author: itayadler

.changeset/fix-readline-tty-curl-bash.md

@@ -0,0 +1,12 @@
+---
+"@frontman-ai/nextjs": patch
+---
+
+Move installer to npx-only, remove curl|bash endpoint, make --server optional
+
+- Remove API server install endpoint (InstallController + /install routes)
+- Make `--server` optional with default `api.frontman.sh`
+- Simplify Readline.res: remove /dev/tty hacks, just use process.stdin
+- Add `config.matcher` to proxy.ts template and auto-edit LLM rules
+- Update marketing site install command from curl to `npx @frontman-ai/nextjs install`
+- Update README install instructions

apps/frontman_server/lib/frontman_server_web/controllers/install_controller.ex

@@ -41,15 +41,6 @@ defmodule FrontmanServerWeb.Router do
     get("/ready", HealthController, :ready)
   end
 
-  # CLI installer routes - no authentication required
-  # Usage: curl https://frontman.example.com/install | bash
-  scope "/install", FrontmanServerWeb do
-    pipe_through(:api)
-
-    get("/", InstallController, :index)
-    get("/nextjs", InstallController, :nextjs)
-  end
-
   scope "/api", FrontmanServerWeb do
     pipe_through([:api_with_session])
 

apps/frontman_server/lib/frontman_server_web/router.ex

@@ -14,9 +14,9 @@ import astroLogo from '../../../assets/frameworks/astro.svg'
 import viteLogo from '../../../assets/frameworks/vite.svg'
 
 const frameworks = [
-	{ id: 'nextjs', name: 'Next.js', logo: nextjsLogo, installPath: '/install/nextjs', port: '3000' },
-	{ id: 'astro', name: 'Astro', logo: astroLogo, installPath: '/install/astro', port: '4321' },
-	{ id: 'vite', name: 'Vite', logo: viteLogo, installPath: '/install/vite', port: '5173' }
+	{ id: 'nextjs', name: 'Next.js', logo: nextjsLogo, command: 'npx @frontman-ai/nextjs install', port: '3000' },
+	{ id: 'astro', name: 'Astro', logo: astroLogo, command: 'npx @frontman-ai/astro install', port: '4321' },
+	{ id: 'vite', name: 'Vite', logo: viteLogo, command: 'npx @frontman-ai/vite install', port: '5173' }
 ]
 ---
 
@@ -39,12 +39,12 @@ const frameworks = [
 
 			<div class="framework-tabs">
 				{frameworks.map((fw, i) => (
-					<button
-						class={`framework-tab ${i === 0 ? 'active' : ''}`}
-						data-framework={fw.id}
-						data-install-path={fw.installPath}
-						data-port={fw.port}
-					>
+				<button
+					class={`framework-tab ${i === 0 ? 'active' : ''}`}
+					data-framework={fw.id}
+					data-command={fw.command}
+					data-port={fw.port}
+				>
 						<img src={fw.logo.src} alt={fw.name} width="24" height="24" loading="lazy" />
 						{fw.name}
 					</button>
@@ -70,7 +70,7 @@ const frameworks = [
 						</div>
 						<div class="terminal-body">
 							<span class="terminal-prompt">$</span>
-							<code data-install-command>curl https://frontman.sh/install/nextjs | bash</code>
+							<code data-install-command>npx @frontman-ai/nextjs install</code>
 							<button class="copy-button" data-copy="install" aria-label="Copy to clipboard">
 								<svg width="16" height="16" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2">
 									<rect x="9" y="9" width="13" height="13" rx="2" ry="2"></rect>
@@ -343,9 +343,9 @@ const frameworks = [
 				tabs.forEach((t) => t.classList.remove('active'))
 				tab.classList.add('active')
 
-				const installPath = tab.getAttribute('data-install-path')
-				if (installCommand && installPath) {
-					installCommand.textContent = `curl https://frontman.sh${installPath} | bash`
+				const command = tab.getAttribute('data-command')
+				if (installCommand && command) {
+					installCommand.textContent = command
 				}
 
 				const port = tab.getAttribute('data-port')

apps/marketing/src/components/blocks/install/InstallSteps.astro

@@ -1,16 +1,18 @@
 // Minimal binding for Node.js readline module (CLI prompts)
 
-// Raw JS implementation using node:readline/promises.
+// Raw JS implementation using node:readline.
 // Returns null on EOF (Ctrl+D) so callers can distinguish it from empty input (Enter).
 // IMPORTANT: resolve(answer) must be called BEFORE rl.close() because
 // rl.close() synchronously emits 'close', which would resolve with null
 // and silently discard the real answer (a Promise resolves only once).
 let question: string => promise<Nullable.t<string>> = %raw(`
   async function(prompt) {
     const readline = await import('node:readline');
+
     const rl = readline.createInterface({
       input: process.stdin,
       output: process.stdout,
+      terminal: true,
     });
     return new Promise((resolve) => {
       rl.on('close', () => resolve(null));
@@ -22,9 +24,9 @@ let question: string => promise<Nullable.t<string>> = %raw(`
   }
 `)
 
-// Check if stdin is a TTY (interactive terminal)
+// Check if we can prompt interactively.
 let isTTY: unit => bool = %raw(`
   function() {
-    return Boolean(process.stdin.isTTY);
+    return !!process.stdin.isTTY;
   }
 `)

libs/bindings/src/Readline.res

@@ -9,14 +9,10 @@ Next.js integration for Frontman - provides development tools and observability
 The fastest way to install Frontman is using our CLI installer:
 
 ```bash
-# Using curl (server host is auto-detected from the URL)
-curl https://api.frontman.sh/install/nextjs | bash
+npx @frontman-ai/nextjs install
 
-# For local development
-curl http://frontman.local:4000/install/nextjs | bash
-
-# Or using npx directly
-npx @frontman-ai/nextjs install --server api.frontman.sh
+# Or with a custom server host
+npx @frontman-ai/nextjs install --server frontman.company.com
 ```
 
 The installer will:
@@ -31,7 +27,7 @@ The installer will:
 npx @frontman-ai/nextjs install [options]
 
 Options:
-  --server <host>   Frontman server host (required)
+  --server <host>   Frontman server host (default: api.frontman.sh)
   --prefix <path>   Target directory (default: current directory)
   --dry-run         Preview changes without writing files
   --skip-deps       Skip dependency installation
@@ -101,6 +97,10 @@ export function proxy(req: NextRequest): NextResponse | Promise<NextResponse> {
   }
   return NextResponse.next();
 }
+
+export const config = {
+  matcher: ['/frontman', '/frontman/:path*'],
+};
 ```
 
 ### OpenTelemetry Setup (Recommended)
@@ -176,6 +176,11 @@ export function proxy(req: NextRequest): NextResponse | Promise<NextResponse> {
   // ... your existing proxy logic below
   return NextResponse.next();
 }
+
+export const config = {
+  // Add Frontman matcher alongside your existing matchers
+  matcher: ['/frontman', '/frontman/:path*', '/your-other-routes/:path*'],
+};
 ```
 
 ### Existing instrumentation.ts

libs/frontman-nextjs/README.md

@@ -1,6 +1,6 @@
 {
 	"name": "@frontman-ai/nextjs",
-	"version": "0.2.1",
+	"version": "0.2.4",
 	"description": "Next.js integration for Frontman - AI-powered development tools and observability",
 	"type": "module",
 	"main": "./dist/index.js",