fix: handle NAT address in subscribe and seeding operations #2192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidates changes from PRs #2172, #2174, and #2175: This builds on PR #2191 (wire protocol cleanup) and adds: - Fix seeding/subscribe operations to handle PeerAddr::Unknown for NAT scenarios - Gateway properly fills in observed addresses from packet source - Improved subscriber address tracking in seeding manager - Update live_tx and connection tests for new address model NOTE: This PR requires review - previous PRs (#2174, #2175) had CHANGES_REQUESTED from Nacho. Submitting consolidated changes for fresh review. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
sanity
changed the title
sanity
changed the title
Collaborator
Author
|
Closing in favor of new PR with rebased changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Peers behind NAT don't know their own external address. When they subscribe to contracts or act as seeders, the protocol needs to properly handle this "unknown address" case.
Previous PRs #2174 and #2175 attempted to fix this but had CHANGES_REQUESTED from Nacho. This PR consolidates those changes for fresh review.
This Solution
Builds on PR #2191 (wire protocol cleanup) and adds:
Subscribe operation fixes:
PeerAddr::Unknownhave their address filled in by the first recipient (gateway)Seeding manager fixes:
SeedingManagertracks subscriber addresses properlyTest updates:
live_txtests updated for new address modelPrevious Feedback
Nacho's review on PRs #2174/#2175 requested changes. Key concerns:
Testing
Related
[AI-assisted - Claude]