Skip to content

Commit daa05b9

Browse files
sanityclaude
andcommitted
fix: use pub_key() instead of peer() in tracing for acceptors
The acceptor's PeerAddr is intentionally Unknown (NAT scenario) since acceptors don't know their external address until the first recipient fills it in from the packet source. Changed tracing statements to use pub_key() instead of peer() to avoid panics on unknown addresses. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent fadf5eb commit daa05b9

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

crates/core/src/operations/connect.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -320,8 +320,8 @@ impl RelayState {
320320
// Use the joiner with updated observed address for response routing
321321
actions.response_target = Some(self.request.joiner.clone());
322322
tracing::info!(
323-
acceptor_peer = %acceptor.peer(),
324-
joiner_peer = %self.request.joiner.peer(),
323+
acceptor_pub_key = %acceptor.pub_key(),
324+
joiner_pub_key = %self.request.joiner.pub_key(),
325325
acceptor_loc = ?acceptor.location,
326326
joiner_loc = ?self.request.joiner.location,
327327
ring_distance = ?dist,
@@ -690,7 +690,7 @@ impl ConnectOp {
690690
match self.state.as_mut() {
691691
Some(ConnectState::WaitingForResponses(state)) => {
692692
tracing::info!(
693-
acceptor = %response.acceptor.peer(),
693+
acceptor_pub_key = %response.acceptor.pub_key(),
694694
acceptor_loc = ?response.acceptor.location,
695695
"connect: joiner received ConnectResponse"
696696
);
@@ -970,14 +970,14 @@ impl Operation for ConnectOp {
970970
let mut updated_payload = payload.clone();
971971
updated_payload.acceptor.peer_addr = PeerAddr::Known(acceptor_addr);
972972
tracing::debug!(
973-
acceptor = %updated_payload.acceptor.peer(),
973+
acceptor_pub_key = %updated_payload.acceptor.pub_key(),
974974
acceptor_addr = %acceptor_addr,
975975
"connect: filled acceptor address from source_addr"
976976
);
977977
updated_payload
978978
} else {
979979
tracing::warn!(
980-
acceptor = %payload.acceptor.peer(),
980+
acceptor_pub_key = %payload.acceptor.pub_key(),
981981
"connect: response received without source_addr, cannot fill acceptor address"
982982
);
983983
payload.clone()
@@ -988,7 +988,7 @@ impl Operation for ConnectOp {
988988

989989
tracing::debug!(
990990
upstream_addr = %upstream_addr,
991-
acceptor = %forward_payload.acceptor.peer(),
991+
acceptor_pub_key = %forward_payload.acceptor.pub_key(),
992992
"connect: forwarding response towards joiner"
993993
);
994994
// Forward response toward the joiner via upstream

0 commit comments

Comments
 (0)