Commit 1fe5585
fix: correct add_subscriber upstream_addr usage per Claude review
- Line 748 (SeekNode): Pass None instead of self.upstream_addr because
subscriber address was already corrected by Gateway. Using upstream_addr
would overwrite with the forwarder's address.
- Line 932 (ReturnSub): Pass None instead of self.upstream_addr because
sender was looked up from source_addr and already has correct address.
Using upstream_addr would use the original requester's address instead
of the provider's.
Addresses Claude code review feedback.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>1 parent 361b8be commit 1fe5585
1 file changed
+10
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
742 | 742 | | |
743 | 743 | | |
744 | 744 | | |
745 | | - | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
746 | 749 | | |
747 | 750 | | |
748 | | - | |
| 751 | + | |
749 | 752 | | |
750 | 753 | | |
751 | 754 | | |
| |||
926 | 929 | | |
927 | 930 | | |
928 | 931 | | |
929 | | - | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
930 | 936 | | |
931 | 937 | | |
932 | | - | |
| 938 | + | |
933 | 939 | | |
934 | 940 | | |
935 | 941 | | |
| |||
0 commit comments