ipasudorule: Use common function to convert hostnames

This patch moves the function used to ensure that hostnames used in
ipasurule are FQDN and unique to module_utils, so it can be used by
other modules than require the same behavior for a hostaname parameter.

Signed-off-by: Rafael Guterres Jeffman <rjeffman@redhat.com>

Author: rjeffman

plugins/module_utils/ansible_freeipa_module.py

@@ -589,6 +589,20 @@ def ensure_fqdn(name, domain):
     return name
 
 
+def convert_param_value_to_unique_fqdn(value):
+    if isinstance(value, (list, tuple)):
+        value = list(
+            set(
+                ensure_fqdn(hostname.lower(), api_get_domain())
+                for hostname in value
+            )
+        )
+    else:
+        value = ensure_fqdn(value.lower(), api_get_domain())
+
+    return value
+
+
 def convert_to_sid(items):
     """Convert all items to SID, if possible."""
     def get_sid(data):

plugins/modules/ipasudorule.py

@@ -369,8 +369,9 @@
 
 from ansible.module_utils.ansible_freeipa_module import \
     IPAAnsibleModule, compare_args_ipa, gen_add_del_lists, gen_add_list, \
-    gen_intersection_list, api_get_domain, ensure_fqdn, netaddr, to_text, \
-    ipalib_errors, convert_param_value_to_lowercase, EntryFactory
+    gen_intersection_list, netaddr, to_text, \
+    ipalib_errors, convert_param_value_to_lowercase, EntryFactory, \
+    convert_param_value_to_unique_fqdn
 
 
 def find_sudorule(module, name):
@@ -502,19 +503,6 @@ def convert_list_of_hostmask(hostmasks):
     ]
 
 
-def convert_list_of_hostnames(hostnames):
-    """Ensure all hostnames in hostnames are lowercase FQDN."""
-    return list(
-        set(
-            ensure_fqdn(value.lower(), api_get_domain())
-            for value in (
-                hostnames if isinstance(hostnames, (list, tuple))
-                else [hostnames]
-            )
-        )
-    )
-
-
 def validate_entry(module, entry, state, action):
     """Ensure entry object is valid."""
     if state == "present" and action == "sudorule":
@@ -596,7 +584,7 @@ def main():
         "hostcategory": {},
         "runasusercategory": {},
         "runasgroupcategory": {},
-        "host": {"convert": [convert_list_of_hostnames]},
+        "host": {"convert": [convert_param_value_to_unique_fqdn]},
         "hostgroup": {"convert": [convert_param_value_to_lowercase]},
         "hostmask": {"convert": [convert_list_of_hostmask]},
         "user": {"convert": [convert_param_value_to_lowercase]},