Conversation
redshiftzero
changed the title
After the tarball and wheels are generated, the package build process should thereafter be reproducible.
rmol
force-pushed
the
ci-reproducibility-check
branch
from
a6984e6 to
1cf40c1
Compare
rmol
approved these changes
Jun 30, 2020
Contributor
rmol
left a comment
rmol
left a comment
There was a problem hiding this comment.
👍 I manually verified the build and hash verification logic. The CI output contains the hashes for verification. Looks great.
I had to rebase to catch it up to master, will merge after CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the tarball and wheels are generated, the deb package build
process should thereafter be reproducible. This PR adds a CI check for
securedrop-log,securedrop-client,securedrop-export,securedrop-proxyto verify that is indeed the case (this was a manual step from https://github.com/freedomofpress/securedrop-workstation/wiki/Workstation-Beta-Acceptance-Tests#packages).I'm putting it in a job in CI as the hashes of the built deb are now printed in the CI build output and they should match the deployed packages. This can be used to cross-check with the build logs in the future (indeed, we could adapt this job to run in the LFS repo we use to commit built debs to check the built deb matches the hash of the package built in CI but I'm leaving that for another day).