Conversation
emkll
approved these changes
Feb 13, 2020
Contributor
emkll
left a comment
emkll
left a comment
There was a problem hiding this comment.
Thanks @redshiftzero looks good to me:
- Sig on sha256sums.txt is correct
- hash of sha256sums.txt matches what is in the build log
- CI passes
- hash of source tarball matches securedrop-sdk on PyPI (wheel hash is different, but source tarball is same hash. nit: Perhaps in the future we can upload the same wheel to pypi? or maybe just the source tarball?
- file paths / URLs are correct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releasing securedrop-sdk 0.0.13 to prod pip mirror (required for merge of freedomofpress/securedrop-client#784)
I'm also removing Werkzeug 0.14.1 as it has a CVE. Due to this we needed to release securedrop-proxy (freedomofpress/securedrop-proxy#66).
build logs: https://github.com/freedomofpress/build-logs/blob/master/pip_mirror/feb13_update
Test plan: