refactor!: tree shaking by adding subpath exports #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RitvikSardana
force-pushed
the
tree-shaking
branch
from
6c769c1 to
310d590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Tree shaking in frappe-ui by using subpath exports.
Now we have sub paths like
/frappe
/icons
Important
BREAKING CHANGE
Removed usage of Icons like
import HelpIcon from "frappe-ui/frappe/Icons/HelpIcon.vue";Removed importing components via nested paths like this
import Badge from "frappe-ui/src/components/Badge/Badge.vue"Migration guide:
To incorporate new changes into your app, read this migration guide.
Before:
After:
